Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1936)

Issue 229430043: Fix libjpeg_turbo svn r64 libjpeg6b compat issue (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by noel chromium
Modified:
8 years, 12 months ago
Reviewers:
darin
CC:
lcamtuf, fdegans
Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/libjpeg_turbo
Visibility:
Public.

Description

Fix libjpeg_turbo svn r64 libjpeg6b compat issue Make the fast path Huffman decoder fallback to the slow decoding path if the Huffman decoding bit sentinel > 16, this to match libjpeg6b decoding by reproducing the exact behavior of jpeg_huff_decode(). When this sentinel check is missing (see bug), libjpeg_turbo can produce two (or more) different decoded images for the same input data depending on how transport systems (eg., networks) packetize the data for delivery to end-systems, web browsers for example. Note: libjpeg6b produces the same decoded image, irrespective of how the input data is placed in network packets. This fix makes libjpeg_turbo do the same for compat with libjpeg6b. TBR=darin@chromium.org BUG=chromium:398235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -8 lines) Patch
M README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M google.patch View 2 chunks +63 lines, -3 lines 0 comments Download
M jdhuff.h View 2 chunks +4 lines, -2 lines 0 comments Download
M jdhuff.c View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5
noel chromium
9 years ago (2015-04-27 11:25:20 UTC) #1
noel chromium
Submitted as http://src.chromium.org/svn/trunk/deps/third_party/libjpeg_turbo@295003 (8ee9bdd068effcf5fe876e401829eadb94569750)
9 years ago (2015-04-27 11:36:18 UTC) #2
noel chromium
Added notes to https://code.google.com/p/chromium/issues/detail?id=479758 about the strange error/complaints from SVN enen thouhg the patch was ...
9 years ago (2015-04-27 11:43:29 UTC) #3
noel chromium
+fdegans as an FYI.
9 years ago (2015-04-27 12:16:48 UTC) #4
noel chromium
8 years, 12 months ago (2015-04-30 00:52:25 UTC) #5
Message was sent while issue was closed.
Rolled into Chromium on https://codereview.chromium.org/1110113002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b