Issue 22870043: Copy the linked D3D compiler DLL to the libGLESv2 product directory.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22870043: Copy the linked D3D compiler DLL to the libGLESv2 product directory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Jamie Madill

Modified:
10 years, 5 months ago

Reviewers:
Zhenyao Mo, Geoff Lang, Shannon Woods

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Copy the linked D3D compiler DLL to the libGLESv2 product directory. Any app that uses angle requires the compiler DLL. BUG=315387 R=zmo@chromium.org,shannonwhoods@chromium.org,geofflang@chromium.org

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	build/common.gypi	View		4 chunks	+6 lines, -4 lines	0 comments	Download
	M	src/build_angle.gypi	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jamie Madill

PTAL... we will also likely need a patch to chromium to fully address the _43 ...

10 years, 5 months ago (2013-11-07 16:19:27 UTC) #1

Shannon Woods

On 2013/11/07 16:19:27, Jamie Madill wrote: > PTAL... we will also likely need a patch ...

10 years, 5 months ago (2013-11-18 16:17:36 UTC) #2

Jamie Madill

10 years, 5 months ago (2013-11-19 22:35:39 UTC) #4

On 2013/11/19 22:23:31, Zhenyao Mo wrote:
> LGTM

https://chromium-review.googlesource.com/#/c/177184/

Expand All Messages | Collapse All Messages