DescriptionFix deployer integration.
Fix the deployer error when the bundle includes
services with constraints.
Updated the deployer dependency. The new tarball
is generated from lp:~frankban/juju-deployer/guienv-fixes
I will take care of proposing that branch later, however,
the diff can be found here:
http://pastebin.ubuntu.com/6376113/
This branch includes the work Benji did for fixing
this issue.
TODO: but these are not release blockers IMHO:
- improve the way we handle the set up of
testing/production environments (as Rick suggested);
- improve the GUI server bundle validation, e.g. disallow
the deployment of local charms, or better check that the
YAML structure is what we expect;
- investigate and fix the bundle deployment error handling:
why errors in the deployer process are not propagated?
Why concurrent.futures explodes with an error while trying
to set up the exception to be propagated in the Future?
This is important because right now an error in the
deployer is not notified, so the deployment is forever
considered in progress and all the other deployments
will be just queued... Actually this is "almost" a release
blocker.
Tests: make unittest
QA:
I used this bundle: http://pastebin.ubuntu.com/6376098/
to live test the branch.
Bootstrap a juju environment, run `make deploy` and then
switch the gui source to lp:juju-gui.
When everything is ready, try to deploy a bundle
which includes num_units != 1, customized config and
constraints. Check the bundle is deployed correctly
and the resulting services have the defined
number of units, options and constraints.
Now try to deploy a bundle with invalid constraints: right
after the drag and drop, the GUI should notify an
invalid constraints error.
https://code.launchpad.net/~frankban/charms/precise/juju-gui/sanitize-constraints-and-other-fun/+merge/194343
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 9
Patch Set 2 : Fix deployer integration. #Patch Set 3 : Fix deployer integration. #
MessagesTotal messages: 8
|