Issue 227380043: Minimal changes to make development work with Git.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 227380043: Minimal changes to make development work with Git. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by kpreid_google

Modified:
9 years ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Visibility:
Public.

More Reviews

Description

* Teach appspot.py about git instead of svn. (myvn will be updated or killed later). * Make build-version handling use git describe. * Some needed .gitignore extensions. @ ed99dadcdd374dc0d14b99cbeeada034ff4960f6

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -22 lines)			Patch
M	.gitignore	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	build.xml	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/appspot.py	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	tools/svnversion-nocolon	View	1 chunk	+2 lines, -9 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

felix8a

lgtm https://codereview.appspot.com/227380043/diff/1/tools/svnversion-nocolon File tools/svnversion-nocolon (right): https://codereview.appspot.com/227380043/diff/1/tools/svnversion-nocolon#newcode4 tools/svnversion-nocolon:4: git describe --always | tr 'A-Z' 'a-z' I ...

9 years ago (2015-04-20 23:00:02 UTC) #2

kpreid_google

9 years ago (2015-04-20 23:03:02 UTC) #3

https://codereview.appspot.com/227380043/diff/1/tools/svnversion-nocolon
File tools/svnversion-nocolon (right):

https://codereview.appspot.com/227380043/diff/1/tools/svnversion-nocolon#newc...
tools/svnversion-nocolon:4: git describe --always | tr 'A-Z' 'a-z'
On 2015/04/20 23:00:02, felix8a wrote:
> I miss the monotonically increasing numbers, but I don't have anything better
in
> mind.

IIRC, we need them too (maybe only in the cajoler or something). My plan is that
anything that is an actual _release_ will get monotonically tagged (starting at
"r6000"), which should be good enough and git describe will use automatically.

> Maybe rename this from 'svnversion-nocolon' to 'cajaversion' or something
> similar.

Will do, later, as part of less blocking-everything-else cleanups.

Expand All Messages | Collapse All Messages