Push environment secrets after connecting API

Push environment secrets after connecting API

This is a much simpler alternative to
https://codereview.appspot.com/22080044/,
implementing the same logic as is present
for the straight-to-state juju.NewConn.

As secrets-pushing will be obsoleted by
synchronous bootstrapping, which is slated
for introduction soon, I have a strong
preference for this option.

There's a drive-by-fix to the EnvironmentSet
API which simplifies testing: allow agent-version
in the parameters as long as it matches the
existing value.

https://code.launchpad.net/~axwalk/juju-core/api-push-env-secrets-take2/+merge/194288

(do not edit description out of merge proposal)

[axw, 2013-11-07 07:07:08]

Please take a look.

[axw, 2013-11-07 07:20:30]

Please take a look.

[jameinel, 2013-11-07 07:22:34]

LGTM

I like this quite a bit better than the ones that poked at api.Open.

[fwereade, 2013-11-07 09:23:25]

LGTM, very nice.

https://codereview.appspot.com/22720043/diff/20001/juju/api.go
File juju/api.go (right):

https://codereview.appspot.com/22720043/diff/20001/juju/api.go#newcode90
juju/api.go:90: return client.EnvironmentSet(cfg)
Ehh, EnvironmentSet requires a whole config, does it? I guess this is a one-time
thing so it's probably not a big problem.

https://codereview.appspot.com/22720043/diff/20001/juju/apiconn_test.go
File juju/apiconn_test.go (right):

https://codereview.appspot.com/22720043/diff/20001/juju/apiconn_test.go#newco...
juju/apiconn_test.go:57: "secret": "fnord",
Why did you leave out the value there?

;p

[axw, 2013-11-07 09:29:17]

https://codereview.appspot.com/22720043/diff/20001/juju/api.go
File juju/api.go (right):

https://codereview.appspot.com/22720043/diff/20001/juju/api.go#newcode90
juju/api.go:90: return client.EnvironmentSet(cfg)
On 2013/11/07 09:23:26, fwereade wrote:
> Ehh, EnvironmentSet requires a whole config, does it? I guess this is a
one-time
> thing so it's probably not a big problem.

True, it's sending more than necessary. This is going to be deleted soon so I'm
just going to land as is (otherwise secrets needs to be converted to
map[string]interface{}... not worth the extra lines).

[rog, 2013-11-07 09:41:42]

LGTM, thanks.

https://codereview.appspot.com/22720043/diff/20001/juju/api.go
File juju/api.go (right):

https://codereview.appspot.com/22720043/diff/20001/juju/api.go#newcode54
juju/api.go:54: // TODO(rog): handle errUnauthorized when the API handles
passwords.
d
(this should have gone ages ago!)