Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 226700043: Fix issue 4355 -- broken beam subdivision

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by Carl
Modified:
8 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix issue 4355 -- broken beam subdivision When beams are subdivided, the number of beams joining the subdivisions should match the length of the subdivision. Previously, the subdivisions were joined by a single beam.

Patch Set 1 #

Patch Set 2 : Respond to comments. Update regtest and really fix the beaming. #

Patch Set 3 : Adjust beam subdivision to work properly on subdividing at baseMoment #

Patch Set 4 : This is a test upload to see if git-cl works with testlily on sourceforge. Please do not review th… #

Patch Set 5 : This is a test patch to see if git-cl can be made to work with testlily on sourceforge. Please do … #

Patch Set 6 : Test patch to see if git-cl will work with testlily on sourceforge. Please do not spend time revie… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -105 lines) Patch
M lily/all-font-metrics.cc View 1 2 3 4 chunks +8 lines, -16 lines 0 comments Download
M lily/all-font-metrics-scheme.cc View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M lily/include/all-font-metrics.hh View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M lily/include/listener.hh View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M lily/include/protected-scm.hh View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M lily/include/smobs.hh View 1 2 3 2 chunks +19 lines, -36 lines 0 comments Download
M lily/include/smobs.tcc View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download
M lily/protected-scm.cc View 1 2 3 1 chunk +1 line, -13 lines 0 comments Download
M lily/scale.cc View 1 2 3 3 chunks +15 lines, -13 lines 0 comments Download
M lily/translator-ctors.cc View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download
M lily/unpure-pure-container.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17
lemzwerg
LGTM.
8 years, 11 months ago (2015-04-25 05:13:22 UTC) #1
uliska
Thank you for picking this up. It is certainly an improvement already. However: In an ...
8 years, 11 months ago (2015-04-25 08:20:52 UTC) #2
uliska
On 2015/04/25 08:20:52, uliska wrote: > Thank you for picking this up. It is certainly ...
8 years, 11 months ago (2015-04-25 08:26:27 UTC) #3
Carl
Ok, so let me see if I understand what you are saying. When we choose ...
8 years, 11 months ago (2015-04-25 11:33:01 UTC) #4
benko.pal
2015-04-25 10:20 GMT+02:00 <lilyliska@googlemail.com>: > Thank you for picking this up. It is certainly an ...
8 years, 11 months ago (2015-04-25 11:54:01 UTC) #5
Carl
Respond to comments. Update regtest and really fix the beaming.
8 years, 11 months ago (2015-04-25 20:44:48 UTC) #6
Carl
On 2015/04/25 11:54:01, benko.pal wrote: > 2015-04-25 10:20 GMT+02:00 <mailto:lilyliska@googlemail.com>: > > Thank you for ...
8 years, 11 months ago (2015-04-25 22:58:56 UTC) #7
uliska
On 2015/04/25 22:58:56, Carl wrote: > On 2015/04/25 11:54:01, benko.pal wrote: > > 2015-04-25 10:20 ...
8 years, 11 months ago (2015-04-26 00:01:14 UTC) #8
uliska
I have now checked the code for my interface idea, and it seems to work. ...
8 years, 11 months ago (2015-04-26 00:22:01 UTC) #9
Carl
baseMoment does have another use. It is used to define the major beaming groups for ...
8 years, 11 months ago (2015-04-26 02:35:34 UTC) #10
lemzwerg
LGTM.
8 years, 11 months ago (2015-04-26 05:58:32 UTC) #11
uliska
On 2015/04/26 02:35:34, Carl wrote: > baseMoment does have another use. It is used to ...
8 years, 11 months ago (2015-04-26 13:49:33 UTC) #12
Trevor Daniels
I can't compile LP at the moment, but LGTM from eye-balling. How pleasing it took ...
8 years, 11 months ago (2015-04-26 20:21:02 UTC) #13
Carl
Adjust beam subdivision to work properly on subdividing at baseMoment
8 years, 10 months ago (2015-05-11 13:40:24 UTC) #14
Carl
This is a test upload to see if git-cl works with testlily on sourceforge. Please ...
8 years, 10 months ago (2015-05-23 22:38:21 UTC) #15
Carl
This is a test patch to see if git-cl can be made to work with ...
8 years, 10 months ago (2015-05-23 22:39:27 UTC) #16
Carl
8 years, 10 months ago (2015-05-23 22:41:40 UTC) #17
Test patch to see if git-cl will work with testlily on sourceforge.  Please do
not spend time reviewing this patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b