Add a basic runtime class with logging and DllMain intercept to syzyasan_hp.dll.

Add a basic runtime class with logging and DllMain intercept to syzyasan_hp.dll.

BUG=
R=chrisha@chromium.org

Committed: https://code.google.com/p/syzygy/source/detail?r=3a684929ec99bf44d621b1e3fcdc81609c354f8f

[cseri, 2015-04-24 04:08:12]

Simple runtime class for the hot patching library. Of course it cannot hot patch
yet but it can log instead!

PTAL.

[chrisha, 2015-04-27 15:28:19]

https://codereview.appspot.com/226640043/diff/1/syzygy/agent/asan/hot_patchin...
File syzygy/agent/asan/hot_patching_asan_runtime.h (right):

https://codereview.appspot.com/226640043/diff/1/syzygy/agent/asan/hot_patchin...
syzygy/agent/asan/hot_patching_asan_runtime.h:38: // Constructs a the class and
initialized the static instance with itself.
For singletons the pattern is to make the constructor private (or protected),
and provide a static accessor that constructs and gets the runtime (ie, your
'runtime' function). Generally, we just call this function 'Get'.

In fact, there's a Singleton class in base you can use do this.

[cseri, 2015-05-02 00:31:59]

Made the runtime a proper singleton and added a test to check if it's loaded by
the dll.

https://codereview.appspot.com/226640043/diff/1/syzygy/agent/asan/hot_patchin...
File syzygy/agent/asan/hot_patching_asan_runtime.h (right):

https://codereview.appspot.com/226640043/diff/1/syzygy/agent/asan/hot_patchin...
syzygy/agent/asan/hot_patching_asan_runtime.h:38: // Constructs a the class and
initialized the static instance with itself.
On 2015/04/27 15:28:19, chrisha wrote:
> For singletons the pattern is to make the constructor private (or protected),
> and provide a static accessor that constructs and gets the runtime (ie, your
> 'runtime' function). Generally, we just call this function 'Get'.
> 
> In fact, there's a Singleton class in base you can use do this.

Done using base::Singleton.

[chrisha, 2015-05-04 13:35:20]

Awesome, this lgtm!

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
File syzygy/agent/asan/hot_patching_asan_runtime.cc (right):

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
syzygy/agent/asan/hot_patching_asan_runtime.cc:33:
std::to_string(reinterpret_cast<int>(instance)) +
Indent these lines another +2.

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
File syzygy/agent/asan/hot_patching_asan_runtime_unittest.cc (right):

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
syzygy/agent/asan/hot_patching_asan_runtime_unittest.cc:27: // This helper class
creates a hot patching Asan instrumented the test_dll.dll.
s/the //

[cseri, 2015-05-04 19:05:58]

Thanks, committing!

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
File syzygy/agent/asan/hot_patching_asan_runtime.cc (right):

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
syzygy/agent/asan/hot_patching_asan_runtime.cc:33:
std::to_string(reinterpret_cast<int>(instance)) +
On 2015/05/04 13:35:20, chrisha wrote:
> Indent these lines another +2.

Done.

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
File syzygy/agent/asan/hot_patching_asan_runtime_unittest.cc (right):

https://codereview.appspot.com/226640043/diff/20001/syzygy/agent/asan/hot_pat...
syzygy/agent/asan/hot_patching_asan_runtime_unittest.cc:27: // This helper class
creates a hot patching Asan instrumented the test_dll.dll.
On 2015/05/04 13:35:20, chrisha wrote:
> s/the //

Done.

[cseri, 2015-05-04 19:18:19]

Committed patchset #3 (id:40001) manually as
3a684929ec99bf44d621b1e3fcdc81609c354f8f (presubmit successful).