Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2011)

Issue 226430043: Issue 4348: Part combiner: move direction handling out of iterator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Dan Eble
Modified:
4 years, 5 months ago
Reviewers:
Keith, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Part combiner: move direction handling out of iterator

Patch Set 1 #

Patch Set 2 : Call \displayLilyMusic output "NOT A BUG" #

Total comments: 1

Patch Set 3 : Fix \displayLilyMusic output for \partcombine(Up|Down) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -67 lines) Patch
M input/regression/display-lily-tests.ly View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M lily/part-combine-iterator.cc View 4 chunks +0 lines, -59 lines 1 comment Download
M ly/music-functions-init.ly View 1 2 1 chunk +18 lines, -6 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 2 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 8
Dan Eble
4 years, 6 months ago (2015-04-18 03:40:06 UTC) #1
Dan Eble
Call \displayLilyMusic output "NOT A BUG"
4 years, 6 months ago (2015-04-19 11:40:31 UTC) #2
dak
On 2015/04/19 11:40:31, Dan Eble wrote: > Call \displayLilyMusic output "NOT A BUG" Why would ...
4 years, 6 months ago (2015-04-19 11:55:40 UTC) #3
Dan Eble
On 2015/04/19 11:55:40, dak wrote: > On 2015/04/19 11:40:31, Dan Eble wrote: > > Call ...
4 years, 6 months ago (2015-04-19 12:30:08 UTC) #4
Dan Eble
Fix \displayLilyMusic output for \partcombine(Up|Down)
4 years, 6 months ago (2015-04-19 17:23:44 UTC) #5
Keith
Looks good to me. https://codereview.appspot.com/226430043/diff/20001/input/regression/display-lily-tests.ly File input/regression/display-lily-tests.ly (right): https://codereview.appspot.com/226430043/diff/20001/input/regression/display-lily-tests.ly#newcode224 input/regression/display-lily-tests.ly:224: \test "NOT A BUG" ##[ ...
4 years, 6 months ago (2015-04-19 18:29:18 UTC) #6
Dan Eble
On 2015/04/19 18:29:18, Keith wrote: > Given that \displayLilyMusic does not reverse-engineer \voiceXxx, it seems ...
4 years, 6 months ago (2015-04-19 18:42:52 UTC) #7
Dan Eble
4 years, 6 months ago (2015-04-19 19:04:43 UTC) #8
On 2015/04/19 18:29:18, Keith wrote:
>
https://codereview.appspot.com/226430043/diff/40001/lily/part-combine-iterato...
> lily/part-combine-iterator.cc:396: SCM lst = get_music ()->get_property
> ("elements");
> Later, it would be good to have PartCombineMusic contain a ContextSpecdMusic
for
> each of the four output Voices and the Devnull in its 'elements.    Instead of

I'm hoping to eliminate PartCombineMusic and instead use simultaneous music with
context change commands, though I'm not sure that it is possible.  This sounds
like an excellent plan B.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b