Issue 226110044: parenthesizeStencil and bracketifyStencil

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 226110044: parenthesizeStencil and bracketifyStencil

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by Valentin Villenave

Modified:
9 years ago

Reviewers:
thomasmorley651

Visibility:
Public.

More Reviews

Description

parenthesizeStencil and bracketifyStencil This is merely an update of a patch sent by Thomas Morley in 2012. See https://codereview.appspot.com/6397043 and https://code.google.com/p/lilypond/issues/detail?id=2646 Update & rebase

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -17 lines)			Patch
M	Documentation/ly-examples/aucun-snippet.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
A	input/regression/parenthesize-bracketify-stencil.ly	View	1 chunk	+44 lines, -0 lines	0 comments	Download
M	ly/music-functions-init.ly	View	2 chunks	+61 lines, -0 lines	0 comments	Download
M	scm/define-markup-commands.scm	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	scm/stencil.scm	View	2 chunks	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Valentin Villenave

9 years ago (2015-04-13 07:49:59 UTC) #1

By the way, Thomas, feel free to use the new diff to update your original patch
set (I tried adding you as "Owner" of the new page, but Rietveld doesn’t seem to
allow it). In which case I’ll just close the new page.

I updated this patch because I thought it would be a pity to abandon it, but if
others think we should let it rot (or wait for a different implementation that
would merge it with the original \parenthesize function, as Janek once
suggested), I certainly won’t mind!

Expand All Messages | Collapse All Messages