Fix ghost inspector initial name validation

Fix ghost inspector initial name validation

QA: deploy mediawiki with the default name.  Make another ghost, and the inspector should correctly show that the default name is invalid.

https://code.launchpad.net/~gary/juju-gui/nameCheck/+merge/194234

(do not edit description out of merge proposal)

[gary.poster, 2013-11-06 21:11:09]

Please take a look.

[jeff.pihach, 2013-11-06 21:20:50]

LGTM with a small comment request.
QA OK
Thanks for this fix!

https://codereview.appspot.com/22500043/diff/1/app/views/viewlets/inspector-h...
File app/views/viewlets/inspector-header.js (right):

https://codereview.appspot.com/22500043/diff/1/app/views/viewlets/inspector-h...
app/views/viewlets/inspector-header.js:59: var name =
pojoModel.displayName.match(/^\(([^)]*)\)$/)[1];
I'd love it if there was a quick comment describing what this regex looks for to
make the code easier to scan.

https://codereview.appspot.com/22500043/diff/1/test/test_ghost_inspector.js
File test/test_ghost_inspector.js (right):

https://codereview.appspot.com/22500043/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:50: env.connect();
Ahh the shibboleth of writing environment tests.....you may proceed.

[gary.poster, 2013-11-06 21:45:58]

*** Submitted:

Fix ghost inspector initial name validation

QA: deploy mediawiki with the default name.  Make another ghost, and the
inspector should correctly show that the default name is invalid.

R=jeff.pihach
CC=
https://codereview.appspot.com/22500043

[gary.poster, 2013-11-06 21:47:48]

On 2013/11/06 21:20:50, jeff.pihach wrote:
...
>
https://codereview.appspot.com/22500043/diff/1/app/views/viewlets/inspector-h...
> app/views/viewlets/inspector-header.js:59: var name =
> pojoModel.displayName.match(/^\(([^)]*)\)$/)[1];
> I'd love it if there was a quick comment describing what this regex looks for
to
> make the code easier to scan.

You want comments?  I'm your man!  Done. :-)

Thanks for the review!