code review 2234042: freetype: make DrawString look more like draw.DrawMask:...

freetype: make DrawString look more like draw.DrawMask: dst, src and
the clip rectangle are now arguments instead of context state.
Also drop the error return.

[nigeltao, 2010-09-17 05:57:30]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rog, 2010-09-17 10:15:34]

LGTM in general, but see below.

http://codereview.appspot.com/2234042/diff/2001/freetype/freetype.go
File freetype/freetype.go (right):

http://codereview.appspot.com/2234042/diff/2001/freetype/freetype.go#newcode205
freetype/freetype.go:205: // DrawString is similar to draw.DrawMask in that it
draws src onto dst through
in DrawMask, mp and sp are aligned with r.Min. this code doesn't do this - i'm
not sure that it's possible to know how the source image will be aligned in dst
without knowing the glyph bounds. essentially, you're using r as a simple clip
rectangle here, but it needs to be more - a clip rectangle *and* a destination
point. i think you need another argument.