Issue 37: App doesn't build from svn

If you checkout the app from SVN it will not build as is because the app is looking for an api_key in the resources that is not provided.

This resolves that issue so that the app will build and provide a dialog with a message explaining what needs to be done to make the app useful.

[Michael Frederick, 2010-09-16 19:48:56]

http://codereview.appspot.com/2232042/diff/1/Npr/res/values/strings.xml
File Npr/res/values/strings.xml (right):

http://codereview.appspot.com/2232042/diff/1/Npr/res/values/strings.xml#newco...
Npr/res/values/strings.xml:83: </string>
Remove tab.

http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
File Npr/src/org/npr/android/news/Main.java (right):

http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
Npr/src/org/npr/android/news/Main.java:233:
ApiConstants.createInstance(key.toString());
This won't work, right?

[jeremy.wadsack, 2010-09-16 20:42:17]

Have removed the tab before </string> in res/values/strings.xml. Can't figure
out how to upload a new patch file, though...

http://codereview.appspot.com/2232042/diff/1/Npr/res/values/strings.xml
File Npr/res/values/strings.xml (right):

http://codereview.appspot.com/2232042/diff/1/Npr/res/values/strings.xml#newco...
Npr/res/values/strings.xml:83: </string>
On 2010/09/16 19:48:56, Michael Frederick wrote:
> Remove tab.

Done.

http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
File Npr/src/org/npr/android/news/Main.java (right):

http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
Npr/src/org/npr/android/news/Main.java:233:
ApiConstants.createInstance(key.toString());
On 2010/09/16 19:48:56, Michael Frederick wrote:
> This won't work, right?

It seems to work enough to launch the application so that the dialog shows. Once
you back out of the dialog, the application closes, so that's all we need.

If I bypass the dialog (in code) it definitely makes the app unusable, which is
what we want.

[jeremy.wadsack, 2010-09-16 20:42:43]

Updated to remove tab

[Michael Frederick, 2010-09-16 20:45:39]

On 2010/09/16 20:42:17, jeremy.wadsack wrote:
> Have removed the tab before </string> in res/values/strings.xml. Can't figure
> out how to upload a new patch file, though...
> 
> http://codereview.appspot.com/2232042/diff/1/Npr/res/values/strings.xml
> File Npr/res/values/strings.xml (right):
> 
>
http://codereview.appspot.com/2232042/diff/1/Npr/res/values/strings.xml#newco...
> Npr/res/values/strings.xml:83: </string>
> On 2010/09/16 19:48:56, Michael Frederick wrote:
> > Remove tab.
> 
> Done.
> 
>
http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
> File Npr/src/org/npr/android/news/Main.java (right):
> 
>
http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
> Npr/src/org/npr/android/news/Main.java:233:
> ApiConstants.createInstance(key.toString());
> On 2010/09/16 19:48:56, Michael Frederick wrote:
> > This won't work, right?
> 
> It seems to work enough to launch the application so that the dialog shows.
Once
> you back out of the dialog, the application closes, so that's all we need.
> 
> If I bypass the dialog (in code) it definitely makes the app unusable, which
is
> what we want.

What happens if you don't include this? Won't it show the dialog and close out
anyway?

[jeremy.wadsack, 2010-09-16 21:03:59]

On Thu, Sep 16, 2010 at 1:45 PM, <mfrederick@google.com> wrote:

> On 2010/09/16 20:42:17, jeremy.wadsack wrote:
>
>
http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
>
>> Npr/src/org/npr/android/news/Main.java:233:
>> ApiConstants.createInstance(key.toString());
>> On 2010/09/16 19:48:56, Michael Frederick wrote:
>> > This won't work, right?
>>
>
>  It seems to work enough to launch the application so that the dialog
>>
> shows. Once
>
>> you back out of the dialog, the application closes, so that's all we
>>
> need.
>
>  If I bypass the dialog (in code) it definitely makes the app unusable,
>>
> which is
>
>> what we want.
>>
>
> What happens if you don't include this? Won't it show the dialog and
> close out anyway?
>


No, the app throws a null ref at line 101 when it tries to use
ApiConstants.instance().

There are 8 references to ApiConstants.instance() and none of them check for
null.

--
Jeremy Wadsack

[Michael Frederick, 2010-09-16 21:10:38]

Ahh. I was thinking that the dialog was preventing the normal sequence.

LGTM


On Thu, Sep 16, 2010 at 5:03 PM, Jeremy Wadsack <jeremy.wadsack@gmail.com>wrote:

>
> On Thu, Sep 16, 2010 at 1:45 PM, <mfrederick@google.com> wrote:
>
>> On 2010/09/16 20:42:17, jeremy.wadsack wrote:
>>
>>
http://codereview.appspot.com/2232042/diff/1/Npr/src/org/npr/android/news/Mai...
>>
>>> Npr/src/org/npr/android/news/Main.java:233:
>>> ApiConstants.createInstance(key.toString());
>>> On 2010/09/16 19:48:56, Michael Frederick wrote:
>>> > This won't work, right?
>>>
>>
>>  It seems to work enough to launch the application so that the dialog
>>>
>> shows. Once
>>
>>> you back out of the dialog, the application closes, so that's all we
>>>
>> need.
>>
>>  If I bypass the dialog (in code) it definitely makes the app unusable,
>>>
>> which is
>>
>>> what we want.
>>>
>>
>> What happens if you don't include this? Won't it show the dialog and
>> close out anyway?
>>
>
>
> No, the app throws a null ref at line 101 when it tries to use
> ApiConstants.instance().
>
> There are 8 references to ApiConstants.instance() and none of them check
> for null.
>
> --
> Jeremy Wadsack
>
>