Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3807)

Issue 22300044: JSON support + minor fixes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
mp+194172, matthew.scott, gary.poster
Visibility:
Public.

Description

JSON support + minor fixes. This branch includes official JSON support for bundle deployments. This branch also contains a number of minor fixes/improvements: - Added the possibility to provide a customized Juju GUI charm URL. - Added support for providing a bundle directory (a dir containing a bundles.yaml file): fix bug 1247181. - Some documentation clean up. - Added an option to decline opening the browser. - The Juju env is bootstrapped passing --debug when quickstart is run in debug mode. - Bumped version up. Tests: `make check`. QA: I uploaded a bundle JSON here: http://pastebin.com/raw.php?i=4mDCcagp So it is possible to check the new features by running the following (expect a scary output): .venv/bin/python juju-quickstart --debug --no-browser \ --gui-charm-url cs:~juju-gui/precise/juju-gui-116 \ -e ec2 http://pastebin.com/raw.php?i=4mDCcagp At the end of the process, locate the GUI url printed before the last debug messages, and check the GUI is up, running and the bundle is deploying. Remember to destroy your ec2 env. Thank you! https://code.launchpad.net/~frankban/juju-quickstart/support-json/+merge/194172 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : JSON support + minor fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -50 lines) Patch
M .bzrignore View 1 chunk +1 line, -0 lines 0 comments Download
M HACKING.rst View 1 chunk +1 line, -1 line 0 comments Download
M README.rst View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M quickstart/app.py View 1 2 chunks +20 lines, -10 lines 0 comments Download
M quickstart/manage.py View 1 5 chunks +36 lines, -10 lines 0 comments Download
M quickstart/tests/helpers.py View 3 chunks +26 lines, -5 lines 0 comments Download
M quickstart/tests/test_app.py View 8 chunks +43 lines, -12 lines 0 comments Download
M quickstart/tests/test_manage.py View 6 chunks +38 lines, -2 lines 0 comments Download
M quickstart/tests/test_utils.py View 2 chunks +19 lines, -6 lines 0 comments Download
M quickstart/utils.py View 1 chunk +4 lines, -1 line 0 comments Download
M setup.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 6 months ago (2013-11-06 15:43:51 UTC) #1
matthew.scott
LGTM, QA Okay. Thanks!
10 years, 6 months ago (2013-11-06 17:23:16 UTC) #2
gary.poster
LGTM with trivial. Thank you! https://codereview.appspot.com/22300044/diff/1/quickstart/app.py File quickstart/app.py (right): https://codereview.appspot.com/22300044/diff/1/quickstart/app.py#newcode123 quickstart/app.py:123: and the optional Juju ...
10 years, 6 months ago (2013-11-06 17:40:43 UTC) #3
frankban
*** Submitted: JSON support + minor fixes. This branch includes official JSON support for bundle ...
10 years, 6 months ago (2013-11-06 18:01:12 UTC) #4
frankban
10 years, 6 months ago (2013-11-06 18:02:10 UTC) #5
Thank you both!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b