Issue 22260045: Migrate prettyprinting to new ASN.1 code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22260045: Migrate prettyprinting to new ASN.1 code

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by ekasper

Modified:
10 years, 5 months ago

Reviewers:
Eran

CC:
cltog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Migrate prettyprinting to new ASN.1 code

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+321 lines, -65 lines)			Patch
M	src/python/ct/crypto/my_asn1/oid.py	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/python/ct/crypto/my_asn1/types.py	View	23 chunks	+222 lines, -43 lines	1 comment	Download
M	src/python/ct/crypto/my_asn1/types_test.py	View	5 chunks	+83 lines, -17 lines	0 comments	Download
M	src/python/ct/crypto/my_asn1/x509.py	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	src/python/ct/crypto/my_asn1/x509_extension.py	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/python/ct/crypto/my_asn1/x509_name.py	View	4 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ekasper

A few unrelated linter fixes also snuck in this CL. But no need to look ...

10 years, 5 months ago (2013-11-06 15:57:07 UTC) #1

Eran

10 years, 5 months ago (2013-11-06 17:33:26 UTC) #2

LGTM

https://codereview.appspot.com/22260045/diff/1/src/python/ct/crypto/my_asn1/t...
File src/python/ct/crypto/my_asn1/types.py (right):

https://codereview.appspot.com/22260045/diff/1/src/python/ct/crypto/my_asn1/t...
src/python/ct/crypto/my_asn1/types.py:616: return ret + [" "*indent + x for x in
nit: spaces before and after '*'.

Expand All Messages | Collapse All Messages