Issue 22250044: Use both GetClientRect and GetWindowRect to determine size of swapchain.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22250044: Use both GetClientRect and GetWindowRect to determine size of swapchain. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by John Bauman

Modified:
10 years, 3 months ago

Reviewers:
Shannon Woods, Jamie Madill

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Use both GetClientRect and GetWindowRect to determine size of swapchain. Chrome makes the client rect of a window larger than the window itself, but only renders into the smaller part. ANGLE should do the same when determining the backbuffer size. BUG=

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -12 lines)			Patch
	M	src/libEGL/Surface.cpp	View		4 chunks	+24 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jamie Madill

On 2013/11/06 02:37:20, John Bauman wrote: LGTM! is there an associated chrome issue?

10 years, 5 months ago (2013-11-06 14:22:47 UTC) #2

Jamie Madill

On 2013/11/06 14:22:47, Jamie Madill wrote: > On 2013/11/06 02:37:20, John Bauman wrote: > > ...

10 years, 5 months ago (2013-11-06 14:24:36 UTC) #3

Jamie Madill

10 years, 5 months ago (2013-11-06 14:26:17 UTC) #4

On 2013/11/06 14:24:36, Jamie Madill wrote:
> On 2013/11/06 14:22:47, Jamie Madill wrote:
> > On 2013/11/06 02:37:20, John Bauman wrote:
> > 
> > LGTM! is there an associated chrome issue?
> 
> ah, i see issue 311405 on chromium is probably related to this

or issue 305432

Expand All Messages | Collapse All Messages