Issue 222080043: code review 222080043: taowm: fix nil dereferences when xgb functions return a...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 222080043: code review 222080043: taowm: fix nil dereferences when xgb functions return a... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by nigeltao

Modified:
10 years, 10 months ago

Reviewers:

CC:
nigeltao, taowm_googlegroups.com

Visibility:
Public.

Description

taowm: fix nil dereferences when xgb functions return a nil result and a nil error.

Patch Set 1 #

Patch Set 2 : diff -r e7b8117a79b48b9d3ed58186f54d011028bed666 https://code.google.com/p/taowm/ #

Patch Set 3 : diff -r e7b8117a79b48b9d3ed58186f54d011028bed666 https://code.google.com/p/taowm/ #

Patch Set 4 : diff -r e7b8117a79b48b9d3ed58186f54d011028bed666 https://code.google.com/p/taowm/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -27 lines)			Patch
M	taowm/actions.go	View	1	3 chunks	+9 lines, -3 lines	0 comments	Download
M	taowm/geom.go	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	taowm/main.go	View	1	4 chunks	+24 lines, -22 lines	0 comments	Download
M	taowm/xinit.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello nigeltao@golang.org (cc: taowm@googlegroups.com), I'd like you to review this change to https://code.google.com/p/taowm/

10 years, 10 months ago (2015-04-01 09:33:51 UTC) #1

nigeltao

10 years, 10 months ago (2015-04-01 09:35:29 UTC) #3

*** Submitted as https://code.google.com/p/taowm/source/detail?r=84cda96db559
***

taowm: fix nil dereferences when xgb functions return a nil result and
a nil error.

TBR=nigeltao
R=nigeltao
CC=taowm
https://codereview.appspot.com/222080043

Expand All Messages | Collapse All Messages