Factor the server start time script out.

Factor the server start time script out.

This is a refactor in anticipation of adding another script.

https://code.launchpad.net/~benji/charmworld/reorganize-scripts/+merge/195425

(do not edit description out of merge proposal)

[benji, 2013-11-15 17:02:56]

Please take a look.

[benji, 2013-11-15 17:14:43]

Here are some comments for the reviewer of this branch.

https://codereview.appspot.com/22190049/diff/1/charmworld/scripts/remove_serv...
File charmworld/scripts/remove_server_start_time.py (right):

https://codereview.appspot.com/22190049/diff/1/charmworld/scripts/remove_serv...
charmworld/scripts/remove_server_start_time.py:1: # Copyright 2012, 2013
Canonical Ltd.  This software is licensed under the
This code is moved from utils.py.

https://codereview.appspot.com/22190049/diff/1/charmworld/scripts/remove_serv...
charmworld/scripts/remove_server_start_time.py:49: def entry_point():
I changed this function name to take advantage of the new more meaningful scope.

https://codereview.appspot.com/22190049/diff/1/charmworld/scripts/tests/test_...
File charmworld/scripts/tests/test_remove_server_start_time.py (right):

https://codereview.appspot.com/22190049/diff/1/charmworld/scripts/tests/test_...
charmworld/scripts/tests/test_remove_server_start_time.py:1: from cStringIO
import StringIO
Most of these tests were just moved from the utils tests.

https://codereview.appspot.com/22190049/diff/1/charmworld/scripts/tests/test_...
charmworld/scripts/tests/test_remove_server_start_time.py:109: def
test_entry_point_exists(self):
This test is new.  I noticed that even though I had moved the code around,
setuptools didn't notice that the endpoint configured in setup.py no long
existed.  We should have a test like this for all the scripts.

https://codereview.appspot.com/22190049/diff/1/charmworld/tests/test_utils.py
File charmworld/tests/test_utils.py (left):

https://codereview.appspot.com/22190049/diff/1/charmworld/tests/test_utils.py...
charmworld/tests/test_utils.py:27: from charmworld.utils import (
Lint should really report duplicate "from"s like this.

https://codereview.appspot.com/22190049/diff/1/charmworld/tests/test_utils.py...
charmworld/tests/test_utils.py:424: 
These tests were moved into the script's test file.

https://codereview.appspot.com/22190049/diff/1/charmworld/tests/test_utils.py
File charmworld/tests/test_utils.py (right):

https://codereview.appspot.com/22190049/diff/1/charmworld/tests/test_utils.py...
charmworld/tests/test_utils.py:9: import os
Importing things from os is silly.

https://codereview.appspot.com/22190049/diff/1/charmworld/utils.py
File charmworld/utils.py (left):

https://codereview.appspot.com/22190049/diff/1/charmworld/utils.py#oldcode258
charmworld/utils.py:258: 
This code was moved into a file just for the "remove server start time" script.

[benji, 2013-11-15 17:35:37]

Please take a look.

[gary.poster, 2013-11-15 18:53:47]

LGTM.  Thank you.