Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(547)

Issue 221710044: note-name-engraver: add user-defined note names support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by Valentin Villenave
Modified:
5 years, 1 month ago
Reviewers:
Dan Eble, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

note-name-engraver: add user-defined note names support Rebase onto master & add regtest This is merely an adaptation from patch #8593046 posted in April 2013 by Fan Ziye. See https://codereview.appspot.com/8593046 and https://code.google.com/p/lilypond/issues/detail?id=1367

Patch Set 1 #

Total comments: 9

Patch Set 2 : Replace NoteNames with a Scheme engraver #

Total comments: 1

Patch Set 3 : Add printOctaveNames property #

Patch Set 4 : Rewrite Note_name_engraver, using more flexible functions and properties #

Total comments: 4

Patch Set 5 : Use existing rassoc function (for now). #

Patch Set 6 : Work with markups rather than simple strings. #

Patch Set 7 : Use make_concat_markup (duh.) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -45 lines) Patch
A input/regression/note-name-context-custom.ly View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M lily/include/lily-imports.hh View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M lily/lily-imports.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M lily/note-name-engraver.cc View 1 2 3 4 5 6 2 chunks +26 lines, -11 lines 0 comments Download
M lily/pitch.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ly/engraver-init.ly View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M scm/chord-name.scm View 1 2 3 4 5 4 chunks +51 lines, -24 lines 0 comments Download
M scm/define-context-properties.scm View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M scm/define-music-display-methods.scm View 1 2 3 5 1 chunk +0 lines, -8 lines 0 comments Download
M scm/translation-functions.scm View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 19
Dan Eble
Is this code going to call an F# an F? https://codereview.appspot.com/221710044/diff/1/lily/note-name-engraver.cc File lily/note-name-engraver.cc (right): https://codereview.appspot.com/221710044/diff/1/lily/note-name-engraver.cc#newcode54 ...
8 years, 11 months ago (2015-04-12 21:12:21 UTC) #1
Dan Eble
Brainstorming: Why not make the context property a callback which receives the pitch as an ...
8 years, 11 months ago (2015-04-13 00:09:27 UTC) #2
Valentin Villenave
Hi Dan, since this is not my patch originally, I’m diving into it without knowing ...
8 years, 11 months ago (2015-04-13 07:43:43 UTC) #3
Valentin Villenave
On 2015/04/13 07:43:43, Valentin Villenave wrote: > All I can think of is the mechanism ...
8 years, 11 months ago (2015-04-13 08:00:57 UTC) #4
Dan Eble
https://codereview.appspot.com/221710044/diff/1/lily/note-name-engraver.cc File lily/note-name-engraver.cc (right): https://codereview.appspot.com/221710044/diff/1/lily/note-name-engraver.cc#newcode58 lily/note-name-engraver.cc:58: for (char c = 'a'; c <= 'g'; c ...
8 years, 11 months ago (2015-04-13 11:14:30 UTC) #5
Valentin Villenave
Replace NoteNames with a Scheme engraver
8 years, 11 months ago (2015-04-13 11:44:40 UTC) #6
Valentin Villenave
8 years, 11 months ago (2015-04-13 11:48:46 UTC) #7
Dan Eble
https://codereview.appspot.com/221710044/diff/20001/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/221710044/diff/20001/scm/scheme-engravers.scm#newcode101 scm/scheme-engravers.scm:101: (let* ((grob (ly:engraver-make-grob engraver 'LyricText event)) * The C++ ...
8 years, 11 months ago (2015-04-14 01:44:34 UTC) #8
Valentin Villenave
Add printOctaveNames property
8 years, 11 months ago (2015-04-14 08:45:27 UTC) #9
Valentin Villenave
Rewrite Note_name_engraver, using more flexible functions and properties
5 years, 1 month ago (2019-02-02 17:46:34 UTC) #10
dak
https://codereview.appspot.com/221710044/diff/60001/lily/general-scheme.cc File lily/general-scheme.cc (right): https://codereview.appspot.com/221710044/diff/60001/lily/general-scheme.cc#newcode150 lily/general-scheme.cc:150: LY_DEFINE (ly_rassoc, "ly:rassoc", I am not sure this is ...
5 years, 1 month ago (2019-02-10 12:23:40 UTC) #11
Valentin Villenave
On 2019/02/10 12:23:40, dak wrote: > lily/general-scheme.cc:150: LY_DEFINE (ly_rassoc, "ly:rassoc", > I am not sure ...
5 years, 1 month ago (2019-02-11 21:22:26 UTC) #12
dak
v.villenave@gmail.com writes: > On 2019/02/10 12:23:40, dak wrote: >> lily/general-scheme.cc:150: LY_DEFINE (ly_rassoc, "ly:rassoc", >> I ...
5 years, 1 month ago (2019-02-11 22:02:11 UTC) #13
Valentin Villenave
Use existing rassoc function (for now).
5 years, 1 month ago (2019-02-11 22:41:57 UTC) #14
Valentin Villenave
Work with markups rather than simple strings.
5 years, 1 month ago (2019-02-12 16:17:34 UTC) #15
Valentin Villenave
On 2019/02/11 22:02:11, dak wrote: > There is alist->hash-table in scm/lily-library.scm Which is a similar ...
5 years, 1 month ago (2019-02-12 16:24:37 UTC) #16
dak
On 2019/02/12 16:24:37, Valentin Villenave wrote: > On 2019/02/11 22:02:11, dak wrote: > > Doing ...
5 years, 1 month ago (2019-02-12 16:53:41 UTC) #17
Valentin Villenave
Use make_concat_markup (duh.)
5 years, 1 month ago (2019-02-12 22:12:23 UTC) #18
Valentin Villenave
5 years, 1 month ago (2019-02-23 09:32:44 UTC) #19
On 2019/02/12 22:12:23, Valentin Villenave wrote:
> Use make_concat_markup (duh.)

Pushed as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=965a6070969789ec4cf...
with additional documentation.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b