Issue 22130044: Migrate X509 time representation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22130044: Migrate X509 time representation

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by ekasper

Modified:
10 years, 5 months ago

Reviewers:
Eran

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Patch Set 2 : revert unwanted change #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -40 lines)			Patch
M	src/python/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/python/ct/crypto/my_asn1/types.py	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/python/ct/crypto/my_asn1/x509.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A +	src/python/ct/crypto/my_asn1/x509_time.py	View	5 chunks	+19 lines, -25 lines	2 comments	Download
A +	src/python/ct/crypto/my_asn1/x509_time_test.py	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Eran

LGTM, one minor comment below. https://codereview.appspot.com/22130044/diff/20001/src/python/ct/crypto/my_asn1/x509_time.py File src/python/ct/crypto/my_asn1/x509_time.py (right): https://codereview.appspot.com/22130044/diff/20001/src/python/ct/crypto/my_asn1/x509_time.py#newcode10 src/python/ct/crypto/my_asn1/x509_time.py:10: class BaseTime(types.ASN1String): Why does ...

10 years, 5 months ago (2013-11-07 16:07:43 UTC) #2

ekasper

10 years, 5 months ago (2013-11-07 16:19:37 UTC) #3

https://codereview.appspot.com/22130044/diff/20001/src/python/ct/crypto/my_as...
File src/python/ct/crypto/my_asn1/x509_time.py (right):

https://codereview.appspot.com/22130044/diff/20001/src/python/ct/crypto/my_as...
src/python/ct/crypto/my_asn1/x509_time.py:10: class BaseTime(types.ASN1String):
On 2013/11/07 16:07:43, Eran wrote:
> Why does it extend an ASN.1 String?

Because time, in ASN.1, is a string.
http://www.obj-sys.com/asn1tutorial/node14.html

(This is carry-over from types.py).

Expand All Messages | Collapse All Messages