Issue 2211045: code review 2211045: os.ReadDir: Windows: check for valid arguments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2211045: code review 2211045: os.ReadDir: Windows: check for valid arguments

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by peterGo

Modified:
13 years, 7 months ago

Reviewers:
brainman

CC:
rsc, brainman, Joe Poirier, golang-dev

Visibility:
Public.

Description

os.ReadDir: Windows: check for valid arguments Fixes issue 1129.

Patch Set 1 #

Patch Set 2 : code review 2211045: os.ReadDir: Windows: check for valid arguments #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/pkg/os/file_windows.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peterGo

Hello rsc (cc: Joe Poirier, brainman, golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 7 months ago (2010-09-24 01:05:43 UTC) #1

rsc

13 years, 7 months ago (2010-09-24 02:07:01 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=942ebc2a6a10 ***

os: check for valid arguments in windows Readdir

Fixes issue 1129.

R=rsc, brainman
CC=Joe Poirier, golang-dev
http://codereview.appspot.com/2211045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages