Changes to JSON serializer to remove serialized-in-serialized data.

.

[onager, 2015-04-07 10:40:19]

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
File dfvfs/serializer/json_serializer.py (right):

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:22: json_dict: a dictionary of the JSON
serialized objects.
See below - please add a description of what this dictionary should look like

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:25: A path specification (instance of
path.PathSpec).
Or the dictionary, if it doesn't contain a __type__ element

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:31: return json_dict
Why return here, versus an exception?

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:55: A dictionary of the JSON serialized
objects.
Can you expand this a little? "Keys are values from
path_spec_factory.Factory.PROPERTY_NAMES" etc.?

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:89: json_string: a JSON string containing
the serialized form.
containing a serialized pathspec

[Joachim Metz, 2015-04-08 06:08:21]

Code updated.

[Joachim Metz, 2015-04-08 06:08:59]

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
File dfvfs/serializer/json_serializer.py (right):

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:22: json_dict: a dictionary of the JSON
serialized objects.
On 2015/04/07 10:40:19, onager wrote:
> See below - please add a description of what this dictionary should look like

Done.

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:25: A path specification (instance of
path.PathSpec).
On 2015/04/07 10:40:19, onager wrote:
> Or the dictionary, if it doesn't contain a __type__ element

Done.

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:31: return json_dict
On 2015/04/07 10:40:19, onager wrote:
> Why return here, versus an exception?

Agree exception might be better.

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:55: A dictionary of the JSON serialized
objects.
On 2015/04/07 10:40:19, onager wrote:
> Can you expand this a little? "Keys are values from
> path_spec_factory.Factory.PROPERTY_NAMES" etc.?

Done.

https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
dfvfs/serializer/json_serializer.py:89: json_string: a JSON string containing
the serialized form.
On 2015/04/07 10:40:19, onager wrote:
> containing a serialized pathspec

Done.

[onager, 2015-04-08 10:46:07]

On 2015/04/08 06:08:59, Joachim Metz wrote:
>
https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
> File dfvfs/serializer/json_serializer.py (right):
> 
>
https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
> dfvfs/serializer/json_serializer.py:22: json_dict: a dictionary of the JSON
> serialized objects.
> On 2015/04/07 10:40:19, onager wrote:
> > See below - please add a description of what this dictionary should look
like
> 
> Done.
> 
>
https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
> dfvfs/serializer/json_serializer.py:25: A path specification (instance of
> path.PathSpec).
> On 2015/04/07 10:40:19, onager wrote:
> > Or the dictionary, if it doesn't contain a __type__ element
> 
> Done.
> 
>
https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
> dfvfs/serializer/json_serializer.py:31: return json_dict
> On 2015/04/07 10:40:19, onager wrote:
> > Why return here, versus an exception?
> 
> Agree exception might be better.
> 
>
https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
> dfvfs/serializer/json_serializer.py:55: A dictionary of the JSON serialized
> objects.
> On 2015/04/07 10:40:19, onager wrote:
> > Can you expand this a little? "Keys are values from
> > path_spec_factory.Factory.PROPERTY_NAMES" etc.?
> 
> Done.
> 
>
https://codereview.appspot.com/220560043/diff/1/dfvfs/serializer/json_seriali...
> dfvfs/serializer/json_serializer.py:89: json_string: a JSON string containing
> the serialized form.
> On 2015/04/07 10:40:19, onager wrote:
> > containing a serialized pathspec
> 
> Done.

One little docstring copy+paste needs a tidy up, otherwise LGTM.

[onager, 2015-04-08 10:46:13]

https://codereview.appspot.com/220560043/diff/20001/dfvfs/serializer/json_ser...
File dfvfs/serializer/json_serializer.py (right):

https://codereview.appspot.com/220560043/diff/20001/dfvfs/serializer/json_ser...
dfvfs/serializer/json_serializer.py:23: The dictionary of the JSON serialized
objects consists of:
Revise docstring - there's only one dict being passed in here.

[Joachim Metz, 2015-04-08 11:05:09]

https://codereview.appspot.com/220560043/diff/20001/dfvfs/serializer/json_ser...
File dfvfs/serializer/json_serializer.py (right):

https://codereview.appspot.com/220560043/diff/20001/dfvfs/serializer/json_ser...
dfvfs/serializer/json_serializer.py:23: The dictionary of the JSON serialized
objects consists of:
On 2015/04/08 10:46:13, onager wrote:
> Revise docstring - there's only one dict being passed in here.

As discussed I'll make the dict in dict behaviour more explicit.

[Joachim Metz, 2015-04-08 16:30:12]

Code Submitted.