Issue 22050044: code review 22050044: go.tools/go/types: add test cases for pending issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22050044: code review 22050044: go.tools/go/types: add test cases for pending issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by gri

Modified:
11 years, 10 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/go/types: add test cases for pending issues The gc compiler is inconsistent how it handles method "mentions" with respect to initialization cycle detection (see issue 6703 for details). Pending a spec clarification, this CL assumes that for a method to be "mentioned", it must be mentioned as a method expression rather than a method value (closer in intent to "syntactic" mention).

Patch Set 1 #

Patch Set 2 : diff -r 792fec216015 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 792fec216015 https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 4 : diff -r 792fec216015 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r cdc328c88cf8 https://code.google.com/p/go.tools #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -13 lines)			Patch
M	go/types/call.go	View	1 2 3	2 chunks	+0 lines, -6 lines	0 comments	Download
M	go/types/check_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	go/types/stdlib_test.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	go/types/testdata/init0.src	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download
A	go/types/testdata/init1.src	View	1 2 3	1 chunk	+73 lines, -0 lines	0 comments	Download
M	go/types/typexpr.go	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 10 months ago (2013-11-05 22:02:03 UTC) #1

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 10 months ago (2013-11-06 17:35:01 UTC) #2

adonovan

LGTM https://codereview.appspot.com/22050044/diff/40001/go/types/testdata/init0.src File go/types/testdata/init0.src (left): https://codereview.appspot.com/22050044/diff/40001/go/types/testdata/init0.src#oldcode79 go/types/testdata/init0.src:79: Revert this file?

11 years, 10 months ago (2013-11-06 17:53:03 UTC) #3

gri

11 years, 10 months ago (2013-11-06 17:55:06 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=8cb7affc0364&repo=tools ***

go.tools/go/types: add test cases for pending issues

The gc compiler is inconsistent how it handles method
"mentions" with respect to initialization cycle detection
(see issue 6703 for details). Pending a spec clarification,
this CL assumes that for a method to be "mentioned", it
must be mentioned as a method expression rather than a
method value (closer in intent to "syntactic" mention).

R=adonovan
CC=golang-dev
https://codereview.appspot.com/22050044

Expand All Messages | Collapse All Messages