Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3776)

Issue 220250043: Major main*.py files refactoring. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by M-A
Modified:
9 years, 1 month ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com, nodir_chromium, iannucci
Base URL:
https://code.google.com/p/swarming@master
Visibility:
Public.

Description

Major files refactoring - auth_service. - Migrate auth_server/backend/, common/ and frontend/ into the main application directory and rename source files for consistency. - Enforce debug parameter on all create_application(). - Remove appstats, the new Cloud Console Trace features can give meaningful data without require intervention from within the app. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=c043b409936afc92b998802b49ed89577e29c0c0

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Update sys.path, migrate common/ too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2402 lines) Patch
M appengine/auth_service/PRESUBMIT.py View 1 1 chunk +1 line, -4 lines 0 comments Download
M appengine/auth_service/app.yaml View 2 chunks +2 lines, -3 lines 0 comments Download
M appengine/auth_service/appengine_config.py View 1 chunk +2 lines, -4 lines 0 comments Download
D appengine/auth_service/backend/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D appengine/auth_service/backend/handlers.py View 1 chunk +0 lines, -42 lines 0 comments Download
D appengine/auth_service/backend/main.py View 1 chunk +0 lines, -27 lines 0 comments Download
D appengine/auth_service/common/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D appengine/auth_service/common/importer.py View 1 1 chunk +0 lines, -454 lines 0 comments Download
D appengine/auth_service/common/importer_test.py View 1 1 chunk +0 lines, -313 lines 0 comments Download
D appengine/auth_service/common/replication.py View 1 1 chunk +0 lines, -429 lines 0 comments Download
D appengine/auth_service/common/replication_smoke_test.py View 1 1 chunk +0 lines, -251 lines 0 comments Download
D appengine/auth_service/common/test_env.py View 1 1 chunk +0 lines, -17 lines 0 comments Download
D appengine/auth_service/common/test_replica_app/app.yaml View 1 1 chunk +0 lines, -23 lines 0 comments Download
D appengine/auth_service/common/test_replica_app/components View 1 1 chunk +0 lines, -1 line 0 comments Download
D appengine/auth_service/common/test_replica_app/main.py View 1 1 chunk +0 lines, -30 lines 0 comments Download
D appengine/auth_service/common/tool_support View 1 1 chunk +0 lines, -1 line 0 comments Download
D appengine/auth_service/frontend/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D appengine/auth_service/frontend/handlers.py View 1 chunk +0 lines, -269 lines 0 comments Download
D appengine/auth_service/frontend/handlers_test.py View 1 chunk +0 lines, -106 lines 0 comments Download
D appengine/auth_service/frontend/main.py View 1 chunk +0 lines, -36 lines 0 comments Download
D appengine/auth_service/frontend/static/js/config_page.js View 1 chunk +0 lines, -62 lines 0 comments Download
D appengine/auth_service/frontend/static/js/services.js View 1 chunk +0 lines, -155 lines 0 comments Download
D appengine/auth_service/frontend/templates/config.html View 1 chunk +0 lines, -29 lines 0 comments Download
D appengine/auth_service/frontend/templates/services.html View 1 chunk +0 lines, -115 lines 0 comments Download
D appengine/auth_service/frontend/test_env.py View 1 chunk +0 lines, -17 lines 0 comments Download
A + appengine/auth_service/handlers_backend.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + appengine/auth_service/handlers_frontend.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + appengine/auth_service/handlers_frontend_test.py View 1 3 chunks +4 lines, -7 lines 0 comments Download
A + appengine/auth_service/importer.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/importer_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + appengine/auth_service/main_backend.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/main_frontend.py View 1 1 chunk +6 lines, -6 lines 0 comments Download
M appengine/auth_service/module-backend.yaml View 1 chunk +1 line, -2 lines 0 comments Download
A + appengine/auth_service/replication.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/replication_smoke_test.py View 1 1 chunk +3 lines, -5 lines 0 comments Download
A + appengine/auth_service/static/js/config_page.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/static/js/services.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/templates/config.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/templates/services.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/test_replica_app/app.yaml View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/test_replica_app/components View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/test_replica_app/main.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6
M-A
I think it makes the project easier to understand and it makes the layout the ...
9 years, 1 month ago (2015-03-26 14:00:49 UTC) #1
vadimsh
auth_service/common can be moved at the root (auth_service/), there's much there. https://codereview.appspot.com/220250043/diff/40001/appengine/auth_service/main_backend.py File appengine/auth_service/main_backend.py (left): ...
9 years, 1 month ago (2015-03-26 21:37:53 UTC) #2
M-A
Update sys.path, migrate common/ too
9 years, 1 month ago (2015-03-27 14:15:46 UTC) #3
M-A
On 2015/03/26 21:37:53, vadimsh wrote: > auth_service/common can be moved at the root (auth_service/), there's ...
9 years, 1 month ago (2015-03-27 14:17:06 UTC) #4
vadimsh
lgtm
9 years, 1 month ago (2015-03-27 20:02:59 UTC) #5
M-A
9 years, 1 month ago (2015-03-29 13:13:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
c043b409936afc92b998802b49ed89577e29c0c0 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b