Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5038)

Issue 22000043: Remove charmworldv3 and APIv2

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by gary.poster
Modified:
10 years, 6 months ago
Reviewers:
bac, rharding, mp+193978
Visibility:
Public.

Description

Remove charmworldv3 and APIv2 For QA, make sure that you can search for bundles (e.g., search for hatch) and make sure that the charm store seems to be working correctly. https://code.launchpad.net/~gary/juju-gui/removeCharmworldV3Flag/+merge/193978 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove charmworldv3 and APIv2 #

Patch Set 3 : Remove charmworldv3 and APIv2 #

Patch Set 4 : Remove charmworldv3 and APIv2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -578 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 2 chunks +3 lines, -7 lines 0 comments Download
M app/store/charmworld.js View 1 chunk +0 lines, -215 lines 0 comments Download
M app/subapps/browser/browser.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/topology/bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_app.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_browser_app.js View 11 chunks +11 lines, -11 lines 0 comments Download
M test/test_browser_charm_details.js View 10 chunks +10 lines, -10 lines 0 comments Download
M test/test_browser_editorial.js View 8 chunks +8 lines, -8 lines 0 comments Download
M test/test_browser_search_view.js View 6 chunks +6 lines, -6 lines 0 comments Download
M test/test_browser_search_widget.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_bundle_details_view.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charmworld.js View 5 chunks +3 lines, -298 lines 0 comments Download
M test/test_environment_view.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/test_ghost_inspector.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_charm.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_inspector_constraints.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_overview.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_settings.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_model.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_service_module.js View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.js View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 6
gary.poster
Please take a look.
10 years, 6 months ago (2013-11-05 18:18:11 UTC) #1
rharding
code looks good, checking qa
10 years, 6 months ago (2013-11-05 18:33:21 UTC) #2
rharding
LGTM qa-ok. Thanks for the update Here we goooooo!
10 years, 6 months ago (2013-11-05 18:39:31 UTC) #3
bac
LGTM, no qa
10 years, 6 months ago (2013-11-05 19:47:39 UTC) #4
gary.poster
*** Submitted: Remove charmworldv3 and APIv2 For QA, make sure that you can search for ...
10 years, 6 months ago (2013-11-05 20:17:36 UTC) #5
gary.poster
10 years, 6 months ago (2013-11-06 01:27:09 UTC) #6
Thank you both!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b