Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5317)

Issue 21980043: Use the new deployer url in our help text

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by gary.poster
Modified:
10 years, 6 months ago
Reviewers:
rharding, mp+193965
Visibility:
Public.

Description

Use the new deployer url in our help text To QA, use the charmworldv3 flag and open up a bundle (search for hatch, for instance) and go to the deploy flag. The instructions there should be helpful and good. https://code.launchpad.net/~gary/juju-gui/deployTabText/+merge/193965 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Use the new deployer url in our help text #

Patch Set 3 : Use the new deployer url in our help text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/bundle.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/subapps/browser/views/bundle.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M app/templates/bundle.handlebars View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
10 years, 6 months ago (2013-11-05 17:06:26 UTC) #1
rharding
LGTM though I think we should decode the %7E in the url for the user.
10 years, 6 months ago (2013-11-05 18:25:25 UTC) #2
gary.poster
On 2013/11/05 18:25:25, rharding wrote: > LGTM though I think we should decode the %7E ...
10 years, 6 months ago (2013-11-05 21:12:05 UTC) #3
gary.poster
10 years, 6 months ago (2013-11-05 21:20:02 UTC) #4
*** Submitted:

Use the new deployer url in our help text

To QA, use the charmworldv3 flag and open up a bundle (search for hatch, for
instance) and go to the deploy flag.  The instructions there should be helpful
and good.

R=rharding
CC=
https://codereview.appspot.com/21980043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b