Issue 219560044: taowm: move offscreenXY away from the int16 underflow d...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 219560044: taowm: move offscreenXY away from the int16 underflow d... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by nigeltao

Modified:
10 years, 10 months ago

Reviewers:

CC:
nigeltao, taowm_googlegroups.com

Visibility:
Public.

Description

taowm: move offscreenXY away from the int16 underflow discontinuity. This works around a session-crasher occasionally seen when using the GIMP's "Perspective" tool.

Patch Set 1 #

Patch Set 2 : diff -r 3853ea2768600b3f80bff90aa73ccdf055436f04 https://code.google.com/p/taowm/ #

Patch Set 3 : diff -r 3853ea2768600b3f80bff90aa73ccdf055436f04 https://code.google.com/p/taowm/ #

Patch Set 4 : diff -r 3853ea2768600b3f80bff90aa73ccdf055436f04 https://code.google.com/p/taowm/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	taowm/geom.go	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello nigeltao@golang.org (cc: taowm@googlegroups.com), I'd like you to review this change to https://code.google.com/p/taowm/

10 years, 10 months ago (2015-04-05 11:25:46 UTC) #1

nigeltao

10 years, 10 months ago (2015-04-05 11:27:24 UTC) #3

*** Submitted as https://code.google.com/p/taowm/source/detail?r=9a591316f3ea
***

taowm: move offscreenXY away from the int16 underflow discontinuity.

This works around a session-crasher occasionally seen when using the GIMP's
"Perspective" tool.

TBR=nigeltao
R=nigeltao
CC=taowm
https://codereview.appspot.com/219560044

Expand All Messages | Collapse All Messages