Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

Issue 21940043: code review 21940043: gosshnew/ssh: implement client using modular connections. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by hanwen-google
Modified:
12 years, 6 months ago
Reviewers:
agl1
CC:
agl1, dave_cheney.net, dfc_golang.org, golang-dev, hanwen-google
Visibility:
Public.

Description

gosshnew/ssh: use modular connection code on the client side.

Patch Set 1 #

Patch Set 2 : diff -r 70dd235cca9d https://code.google.com/p/gosshnew #

Patch Set 3 : diff -r 70dd235cca9d https://code.google.com/p/gosshnew #

Total comments: 8

Patch Set 4 : diff -r 70dd235cca9d https://code.google.com/p/gosshnew #

Patch Set 5 : diff -r 70dd235cca9d https://code.google.com/p/gosshnew #

Patch Set 6 : diff -r 70dd235cca9d https://code.google.com/p/gosshnew #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -535 lines) Patch
M ssh/client.go View 1 5 chunks +32 lines, -292 lines 0 comments Download
M ssh/messages.go View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ssh/messages_test.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ssh/mux.go View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M ssh/session.go View 1 2 3 12 chunks +110 lines, -150 lines 0 comments Download
M ssh/session_test.go View 1 2 chunks +1 line, -25 lines 0 comments Download
M ssh/tcpip.go View 1 2 3 6 chunks +36 lines, -65 lines 0 comments Download

Messages

Total messages: 4
hanwen-google
Hello agl@golang.org, dave@cheney.net (cc: agl@golang.org, dfc@golang.org, golang-dev@googlegroups.com, hanwen@google.com), I'd like you to review this change ...
12 years, 6 months ago (2013-11-05 16:13:00 UTC) #1
agl1
LGTM https://codereview.appspot.com/21940043/diff/40001/ssh/session.go File ssh/session.go (right): https://codereview.appspot.com/21940043/diff/40001/ssh/session.go#newcode192 ssh/session.go:192: ok, err := s.ch.SendRequest("pty-req", true, marshal(0, req)) maybe ...
12 years, 6 months ago (2013-11-05 23:25:20 UTC) #2
hanwen-google
https://codereview.appspot.com/21940043/diff/40001/ssh/session.go File ssh/session.go (right): https://codereview.appspot.com/21940043/diff/40001/ssh/session.go#newcode192 ssh/session.go:192: ok, err := s.ch.SendRequest("pty-req", true, marshal(0, req)) On 2013/11/05 ...
12 years, 6 months ago (2013-11-06 09:56:38 UTC) #3
hanwen-google
12 years, 6 months ago (2013-11-06 10:13:01 UTC) #4
*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=889d17fec13d
***

gosshnew/ssh: use modular connection code on the client side.

R=agl, dave
CC=agl, dfc, golang-dev, hanwen
https://codereview.appspot.com/21940043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b