Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(111)

Issue 2192044: Makes typical property creation faster. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by MarkM
Modified:
14 years, 10 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Some code and benchmarks such as http://www2.webkit.org/perf/sunspider-0.9/access-binary-trees.html create properties almost as often as they use them. These frequent property creations are of absent properties on extensible objects, so I added a shortcut to .w___ for that case. access-binary-trees.html is now about twice as fast.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Makes typical property creation faster. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M doc/html/es5-talk/es5-talk.ppt View Binary file 0 comments Download
M src/com/google/caja/es53.js View 1 7 chunks +54 lines, -10 lines 0 comments Download

Messages

Total messages: 3
MarkM
15 years, 9 months ago (2010-09-18 21:43:34 UTC) #1
metaweta
LGTM. http://codereview.appspot.com/2192044/diff/1/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right): http://codereview.appspot.com/2192044/diff/1/src/com/google/caja/es53.js#newcode4504 src/com/google/caja/es53.js:4504: name = '' + name; Ankur pointed out ...
15 years, 9 months ago (2010-09-21 22:43:16 UTC) #2
metaweta
14 years, 10 months ago (2011-08-22 16:41:58 UTC) #3
On 2010/09/21 22:43:16, metaweta wrote:
> LGTM.
> 
> http://codereview.appspot.com/2192044/diff/1/src/com/google/caja/es53.js
> File src/com/google/caja/es53.js (right):
> 
>
http://codereview.appspot.com/2192044/diff/1/src/com/google/caja/es53.js#newc...
> src/com/google/caja/es53.js:4504: name = '' + name;
> Ankur pointed out that these aren't interchangeable; this form invokes valueOf
> first.  I need to go back and check all the places where either form is used
and
> make sure we're doing the right thing.

What's the status of this CL?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b