Issue 21880043: Log error message when baskets are rejected.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 21880043: Log error message when baskets are rejected.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by bac

Modified:
10 years, 6 months ago

Reviewers:
mp+193933, benji

Visibility:
Public.

Description

Log error message when baskets are rejected. https://code.launchpad.net/~bac/charmworld/bundle-reject-logging/+merge/193933 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Log error message when baskets are rejected. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -8 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/jobs/ingest.py	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	charmworld/jobs/tests/test_ingest.py	View	3 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

benji

10 years, 6 months ago (2013-11-05 14:32:30 UTC) #2

LGTM

https://codereview.appspot.com/21880043/diff/1/charmworld/jobs/ingest.py
File charmworld/jobs/ingest.py (right):

https://codereview.appspot.com/21880043/diff/1/charmworld/jobs/ingest.py#newc...
charmworld/jobs/ingest.py:337: def get_deployer_config(fs, basket_data):
No docstrings as far as the eye can see.

Expand All Messages | Collapse All Messages