More clean up of output modules and changes for issue #5.

Depends on CL 220330043

git status -s
 M plaso/frontend/psort_test.py
 M plaso/output/__init__.py
 M plaso/output/dynamic.py
 M plaso/output/elastic.py
 M plaso/output/interface.py
 M plaso/output/interface_test.py
 M plaso/output/json_out.py
 M plaso/output/l2t_csv.py
 D plaso/output/l2t_tln.py
 D plaso/output/l2t_tln_test.py
 M plaso/output/mysql_4n6.py
 M plaso/output/pstorage.py
 M plaso/output/rawpy.py
 M plaso/output/sqlite_4n6.py
 M plaso/output/timesketch_out.py
 M plaso/output/tln.py
 M plaso/output/tln_test.py
 M utils/common.sh
A  utils/pylintrc-1.4.0


Note that tln.py and l2t_tln.py have been merged.

[Joachim Metz, 2015-03-26 11:03:31]

https://codereview.appspot.com/218250043/diff/1/utils/common.sh
File utils/common.sh (right):

https://codereview.appspot.com/218250043/diff/1/utils/common.sh#newcode40
utils/common.sh:40: # Check if pyling version is < 1.1.0
pyling => pylint

[Joachim Metz, 2015-03-27 07:26:01]

Splitting off the linter changes to: https://codereview.appspot.com/220330043/

[kiddi, 2015-03-27 20:15:52]

few comments

https://codereview.appspot.com/218250043/diff/1/plaso/output/interface.py
File plaso/output/interface.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/interface.py#new...
plaso/output/interface.py:222: self._file_object.WriteLine(line)
isn't this unnecessary overhead? To have this instead of just calling
self._file_object.WriteLine?

https://codereview.appspot.com/218250043/diff/1/plaso/output/l2t_csv.py
File plaso/output/l2t_csv.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/l2t_csv.py#newco...
plaso/output/l2t_csv.py:32: formatter_mediator: the formatter mediator object
(instance of
the other args start with a capital after :, make it consistent (All start
lower-case or all upper-case)

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py
File plaso/output/tln.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode34
plaso/output/tln.py:34: formatter_mediator: the formatter mediator object
(instance of
the other args start with capital letter, make this the same

https://codereview.appspot.com/218250043/diff/1/utils/common.sh
File utils/common.sh (right):

https://codereview.appspot.com/218250043/diff/1/utils/common.sh#newcode40
utils/common.sh:40: # Check if pyling version is < 1.1.0
On 2015/03/26 11:03:31, Joachim Metz wrote:
> pyling => pylint

yes... fix that

https://codereview.appspot.com/218250043/diff/1/utils/common.sh#newcode47
utils/common.sh:47: # Check if pyling version is < 1.4.0
same pyling here

[Joachim Metz, 2015-03-27 20:31:01]

https://codereview.appspot.com/218250043/diff/1/plaso/output/interface.py
File plaso/output/interface.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/interface.py#new...
plaso/output/interface.py:222: self._file_object.WriteLine(line)
On 2015/03/27 20:15:52, kiddi wrote:
> isn't this unnecessary overhead? To have this instead of just calling
> self._file_object.WriteLine?

I thinks file object should be refactored away to use CLIOutputWriter. Having 1
function in the interface makes this easier, both an attribute and method name
lookup are done in the same manner within the Python core, so I'm guessing that
the overhead will be minimum in terms of performance.

https://codereview.appspot.com/218250043/diff/1/plaso/output/l2t_csv.py
File plaso/output/l2t_csv.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/l2t_csv.py#newco...
plaso/output/l2t_csv.py:32: formatter_mediator: the formatter mediator object
(instance of
On 2015/03/27 20:15:52, kiddi wrote:
> the other args start with a capital after :, make it consistent (All start
> lower-case or all upper-case)

Done.

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py
File plaso/output/tln.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode34
plaso/output/tln.py:34: formatter_mediator: the formatter mediator object
(instance of
On 2015/03/27 20:15:52, kiddi wrote:
> the other args start with capital letter, make this the same

done, and did the other files as well

https://codereview.appspot.com/218250043/diff/1/utils/common.sh
File utils/common.sh (right):

https://codereview.appspot.com/218250043/diff/1/utils/common.sh#newcode47
utils/common.sh:47: # Check if pyling version is < 1.4.0
On 2015/03/27 20:15:52, kiddi wrote:
> same pyling here

moved to a different CL

[Joachim Metz, 2015-03-27 20:31:30]

Code updated.

[onager, 2015-03-30 09:07:28]

Couple of comments

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py
File plaso/output/tln.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode16
plaso/output/tln.py:16: class
TlnBaseOutputFormatter(interface.FileLogOutputFormatter):
TLN, not Tln

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode17
plaso/output/tln.py:17: """Base class for a TLN output modules."""
-a

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode29
plaso/output/tln.py:29: """Initializes the log output formatter object.
log output?

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode134
plaso/output/tln.py:134: class TlnOutputFormatter(TlnBaseOutputFormatter):
TLN

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode184
plaso/output/tln.py:184: class L2tTlnOutputFormatter(TlnBaseOutputFormatter):
L2TTLN

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode224
plaso/output/tln.py:224: distinction between these two types as well as
extracting the format
This docstring is confusing, and doesn't seem necessary for understanding the
method. Delete?

[Joachim Metz, 2015-03-30 20:34:24]

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py
File plaso/output/tln.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode16
plaso/output/tln.py:16: class
TlnBaseOutputFormatter(interface.FileLogOutputFormatter):
On 2015/03/30 09:07:27, onager wrote:
> TLN, not Tln

Acknowledged.

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode17
plaso/output/tln.py:17: """Base class for a TLN output modules."""
On 2015/03/30 09:07:28, onager wrote:
> -a

going for -s instead ;)

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode29
plaso/output/tln.py:29: """Initializes the log output formatter object.
On 2015/03/30 09:07:27, onager wrote:
> log output?

Yeah original naming it is horrible I'll change them all to output module.

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode134
plaso/output/tln.py:134: class TlnOutputFormatter(TlnBaseOutputFormatter):
On 2015/03/30 09:07:28, onager wrote:
> TLN

Done.

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode184
plaso/output/tln.py:184: class L2tTlnOutputFormatter(TlnBaseOutputFormatter):
On 2015/03/30 09:07:28, onager wrote:
> L2TTLN

Done.

https://codereview.appspot.com/218250043/diff/1/plaso/output/tln.py#newcode224
plaso/output/tln.py:224: distinction between these two types as well as
extracting the format
On 2015/03/30 09:07:28, onager wrote:
> This docstring is confusing, and doesn't seem necessary for understanding the
> method. Delete?

SGTM, this is largely from the original code and this should probably go into
how to write an output module codelab.

[Joachim Metz, 2015-03-30 20:35:45]

Code updated.

[kiddi, 2015-03-31 23:30:36]

LGTM

https://codereview.appspot.com/218250043/diff/1/plaso/output/interface.py
File plaso/output/interface.py (right):

https://codereview.appspot.com/218250043/diff/1/plaso/output/interface.py#new...
plaso/output/interface.py:222: self._file_object.WriteLine(line)
On 2015/03/27 20:31:01, Joachim Metz wrote:
> On 2015/03/27 20:15:52, kiddi wrote:
> > isn't this unnecessary overhead? To have this instead of just calling
> > self._file_object.WriteLine?
> 
> I thinks file object should be refactored away to use CLIOutputWriter. Having
1
> function in the interface makes this easier, both an attribute and method name
> lookup are done in the same manner within the Python core, so I'm guessing
that
> the overhead will be minimum in terms of performance.

ok, if the intention is to get rid of the file object into an output writer
one... then this is fine

but can you add a todo?

[Joachim Metz, 2015-04-01 05:36:08]

> but can you add a todo?

One is here: https://github.com/log2timeline/plaso/issues/123

[Joachim Metz, 2015-04-01 05:51:27]

Code Submitted.