Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160)

Issue 218070: code review 218070: First run at a Programming FAQ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by adg
Modified:
14 years, 4 months ago
Reviewers:
CC:
r, rsc, iant, gri, golang-dev
Visibility:
Public.

Description

First run at a Programming FAQ Moved a couple of FAQs from the main FAQ, and added some others

Patch Set 1 #

Patch Set 2 : code review 218070: First run at a Programming FAQ #

Total comments: 3

Patch Set 3 : code review 218070: First run at a Programming FAQ #

Total comments: 10

Patch Set 4 : code review 218070: First run at a Programming FAQ #

Total comments: 18

Patch Set 5 : code review 218070: First run at a Programming FAQ #

Total comments: 2

Patch Set 6 : code review 218070: First run at a Programming FAQ #

Patch Set 7 : code review 218070: First run at a Programming FAQ #

Patch Set 8 : code review 218070: First run at a Programming FAQ #

Total comments: 7

Patch Set 9 : code review 218070: First run at a Programming FAQ #

Total comments: 10

Patch Set 10 : code review 218070: First run at a Programming FAQ #

Total comments: 6

Patch Set 11 : code review 218070: First run at a Programming FAQ #

Total comments: 5

Patch Set 12 : code review 218070: First run at a Programming FAQ #

Total comments: 1

Patch Set 13 : code review 218070: First run at a Programming FAQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -56 lines) Patch
M doc/go_faq.html View 1 2 3 3 chunks +5 lines, -56 lines 0 comments Download
A doc/go_programming_faq.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +271 lines, -0 lines 0 comments Download
M lib/godoc/godoc.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27
adg
Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 5 months ago (2010-02-23 18:34:33 UTC) #1
iant
FYI http://codereview.appspot.com/218070/diff/5/6 File doc/go_faq.html (right): http://codereview.appspot.com/218070/diff/5/6#newcode87 doc/go_faq.html:87: programs. The Go team is small and we ...
14 years, 5 months ago (2010-02-23 18:53:51 UTC) #2
adg
Hello r, rsc, iant (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 5 months ago (2010-02-23 18:56:53 UTC) #3
rsc
looks like a good start. might also close issue 232. http://codereview.appspot.com/218070/diff/11/12 File doc/go_faq.html (right): http://codereview.appspot.com/218070/diff/11/12#newcode87 ...
14 years, 5 months ago (2010-02-23 19:21:42 UTC) #4
gri
FYI. http://codereview.appspot.com/218070/diff/11/13 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/11/13#newcode10 doc/go_programming_faq.html:10: Source files can refer to items from different ...
14 years, 5 months ago (2010-02-23 19:24:20 UTC) #5
adg
Hello r, rsc, iant, gri (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 5 months ago (2010-02-23 20:04:14 UTC) #6
r
lots of comments but this is a great start http://codereview.appspot.com/218070/diff/19/21 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/19/21#newcode5 doc/go_programming_faq.html:5: ...
14 years, 5 months ago (2010-02-23 21:16:44 UTC) #7
adg
On 23 February 2010 13:16, <r@golang.org> wrote: > http://codereview.appspot.com/218070/diff/19/21#newcode87 > doc/go_programming_faq.html:87: useful when defining methods ...
14 years, 5 months ago (2010-02-23 22:04:21 UTC) #8
adg
On 23 February 2010 13:16, <r@golang.org> wrote: > http://codereview.appspot.com/218070/diff/19/21#newcode168 > doc/go_programming_faq.html:168: penalty involved in sending ...
14 years, 5 months ago (2010-02-23 22:13:53 UTC) #9
adg
Hello r, rsc, iant, gri (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 5 months ago (2010-02-23 22:46:16 UTC) #10
adg
There are some parts of this (eg "causing semantic ugliness") that are placeholders. Just thought ...
14 years, 5 months ago (2010-02-23 22:54:01 UTC) #11
r2
On Feb 24, 2010, at 9:03 AM, Andrew Gerrand wrote: > On 23 February 2010 ...
14 years, 5 months ago (2010-02-23 22:57:29 UTC) #12
r
http://codereview.appspot.com/218070/diff/29/31 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/29/31#newcode161 doc/go_programming_faq.html:161: what you'll probably see instead is <code>c, c, c</code>. ...
14 years, 5 months ago (2010-02-24 03:27:19 UTC) #13
adg
Hello r, rsc, iant, gri (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 4 months ago (2010-03-01 05:06:28 UTC) #14
rsc
will take a look tomorrow. heading to bed now. On Sun, Feb 28, 2010 at ...
14 years, 4 months ago (2010-03-01 05:39:50 UTC) #15
iant
LGTM http://codereview.appspot.com/218070/diff/3011/2008 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/3011/2008#newcode16 doc/go_programming_faq.html:16: Map and slice values are also handles pointing ...
14 years, 4 months ago (2010-03-01 23:12:40 UTC) #16
gri
FYI. - Robert http://codereview.appspot.com/218070/diff/3011/2008 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/3011/2008#newcode11 doc/go_programming_faq.html:11: value to the parameter. Copying a ...
14 years, 4 months ago (2010-03-01 23:27:46 UTC) #17
adg
Hello r, rsc, iant, gri (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 4 months ago (2010-03-02 00:42:12 UTC) #18
r
http://codereview.appspot.com/218070/diff/2013/3021 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/2013/3021#newcode12 doc/go_programming_faq.html:12: the pointer, not the data it points at. points ...
14 years, 4 months ago (2010-03-02 00:55:38 UTC) #19
adg
Hello r, rsc, iant, gri (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 4 months ago (2010-03-03 02:17:38 UTC) #20
rsc
http://codereview.appspot.com/218070/diff/2018/2020 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/2018/2020#newcode5 doc/go_programming_faq.html:5: <h3 id="When_should_I_pass_by_value"> Go through and make sure the id's ...
14 years, 4 months ago (2010-03-03 02:39:51 UTC) #21
adg
Hello r, rsc, iant, gri (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 4 months ago (2010-03-03 03:01:11 UTC) #22
r
http://codereview.appspot.com/218070/diff/3030/2024 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/3030/2024#newcode37 doc/go_programming_faq.html:37: points to. Otherwise, it is often syntactically simpler to ...
14 years, 4 months ago (2010-03-03 04:33:39 UTC) #23
adg
Hello r, rsc, iant, gri (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 4 months ago (2010-03-03 04:53:47 UTC) #24
rsc
LGTM (but wait for other LGTMs to submit) http://codereview.appspot.com/218070/diff/3032/2032 File doc/go_programming_faq.html (right): http://codereview.appspot.com/218070/diff/3032/2032#newcode243 doc/go_programming_faq.html:243: <h3 ...
14 years, 4 months ago (2010-03-04 01:37:09 UTC) #25
r2
LGTM
14 years, 4 months ago (2010-03-04 01:38:16 UTC) #26
adg
14 years, 4 months ago (2010-03-04 01:56:18 UTC) #27
*** Submitted as http://code.google.com/p/go/source/detail?r=68b71443bb29 ***

First run at a Programming FAQ

Moved a couple of FAQs from the main FAQ, and added some others

R=r, rsc, iant, gri
CC=golang-dev
http://codereview.appspot.com/218070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b