Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 218010043: nss-1118245-v6

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by kaie
Modified:
7 years ago
Reviewers:
mt, wtc1
Visibility:
Public.

Description

nss-1118245-v6

Patch Set 1 #

Total comments: 30
Unified diffs Side-by-side diffs Delta from patch set Stats (+4407 lines, -4468 lines) Patch
M lib/certhigh/certhigh.c View 30 chunks +572 lines, -559 lines 3 comments Download
M lib/certhigh/certhtml.c View 3 chunks +211 lines, -210 lines 0 comments Download
M lib/certhigh/certreq.c View 10 chunks +98 lines, -91 lines 1 comment Download
M lib/certhigh/certvfy.c View 37 chunks +954 lines, -959 lines 14 comments Download
M lib/certhigh/certvfypkix.c View 61 chunks +694 lines, -703 lines 3 comments Download
M lib/certhigh/crlv2.c View 5 chunks +47 lines, -47 lines 0 comments Download
M lib/certhigh/ocsp.h View 16 chunks +38 lines, -41 lines 0 comments Download
M lib/certhigh/ocsp.c View 213 chunks +1350 lines, -1418 lines 5 comments Download
M lib/certhigh/ocspi.h View 5 chunks +20 lines, -18 lines 0 comments Download
M lib/certhigh/ocspsig.c View 16 chunks +172 lines, -167 lines 2 comments Download
M lib/certhigh/ocspt.h View 11 chunks +53 lines, -53 lines 0 comments Download
M lib/certhigh/ocspti.h View 16 chunks +53 lines, -56 lines 0 comments Download
M lib/certhigh/xcrldist.c View 1 chunk +145 lines, -146 lines 2 comments Download

Messages

Total messages: 2
wtc1
In general the formatting is good. I found some problems. 1. Some lines are too ...
7 years, 2 months ago (2015-04-17 22:26:48 UTC) #1
mt
7 years ago (2015-06-18 00:15:44 UTC) #2
https://codereview.appspot.com/218010043/diff/1/lib/certhigh/certhigh.c
File lib/certhigh/certhigh.c (right):

https://codereview.appspot.com/218010043/diff/1/lib/certhigh/certhigh.c#newco...
lib/certhigh/certhigh.c:379: (trust->emailFlags & (CERTDB_VALID_CA |
CERTDB_VALID_PEER)) ||
On 2015/04/17 22:26:46, wtc1 wrote:
> Could you please check if these lines are longer than 80 characters?

This seems to be due to case labels being indented.  Could we fix that by having
case labels flush with the outer switch statement?

e.g.,

switch(x) {
case y:
    doY();
    break;
default:
}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b