Issue 21580044: code review 21580044: freetype/truetype: adjust ends slice when hinting a com...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 21580044: code review 21580044: freetype/truetype: adjust ends slice when hinting a com... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by nigeltao

Modified:
10 years, 7 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-dev, remyoudompheng

Visibility:
Public.

Description

freetype/truetype: adjust ends slice when hinting a compound glyph. Successfully hint all of DejaVu Sans Oblique, barring 4 exceptions that are errors in the upstream C Freetype project. See http://lists.nongnu.org/archive/html/freetype/2013-11/msg00004.html for details.

Patch Set 1 #

Patch Set 2 : diff -r 9cad0dfd1b90 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 9cad0dfd1b90 https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r 9cad0dfd1b90 https://code.google.com/p/freetype-go #

Patch Set 5 : diff -r 9cad0dfd1b90 https://code.google.com/p/freetype-go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -3 lines)			Patch
	M	freetype/truetype/glyph.go	View	1	1 chunk	+16 lines, -2 lines	0 comments	Download
	M	freetype/truetype/truetype_test.go	View	1 2 3	3 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com, remyoudompheng@gmail.com), I'd like you to review this change to https://code.google.com/p/freetype-go

10 years, 8 months ago (2013-11-05 00:07:48 UTC) #1

nigeltao

10 years, 7 months ago (2013-11-06 21:55:18 UTC) #3

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=d81fe028cc21 ***

freetype/truetype: adjust ends slice when hinting a compound glyph.

Successfully hint all of DejaVu Sans Oblique, barring 4 exceptions
that are errors in the upstream C Freetype project. See
http://lists.nongnu.org/archive/html/freetype/2013-11/msg00004.html
for details.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/21580044

Expand All Messages | Collapse All Messages