Issue 2150041: Change audio test to silence; style fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2150041: Change audio test to silence; style fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by jeremy.wadsack

Modified:
13 years, 7 months ago

Reviewers:
Michael Frederick

Base URL:
http://npr-android-app.googlecode.com/svn/trunk/

Visibility:
Public.

Changed the audio test file to a second of silence. Added other formats for this file for later testing. Renamed Stream tests to test to match style

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -105 lines)			Patch
M	Npr/.classpath	View	1 chunk	+8 lines, -9 lines	0 comments	Download
D	Npr_Test/res/raw/laser.mp3	View	Binary file		0 comments	Download
A	Npr_Test/res/raw/one_second_silence_3gp.3gp	View	Binary file		0 comments	Download
A	Npr_Test/res/raw/one_second_silence_m4a.m4a	View	Binary file		0 comments	Download
A	Npr_Test/res/raw/one_second_silence_mp3.mp3	View	Binary file		0 comments	Download
M	Npr_Test/src/org/npr/android/news/PlaybackServiceTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	Npr_Test/src/org/npr/android/news/StreamProxyTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	Npr_Test/src/org/npr/android/news/StreamProxyTests.java	View	1 chunk	+0 lines, -93 lines	0 comments	Download
M	Npr_Test/src/org/npr/android/test/HttpRawResourceServer.java	View	2 chunks	+25 lines, -0 lines	0 comments	Download

Total messages: 4

jeremy.wadsack

A couple minor updates to clean up the test system. Replaced the audio file. Changed ...

13 years, 8 months ago (2010-09-02 23:42:00 UTC) #2

Michael Frederick

13 years, 7 months ago (2010-09-14 16:12:08 UTC) #4

LGTM

Thanks for the excellent work so far! Having a real test framework will be huge
going forward.