Issue 2148044: PlsParser fails to read files correctly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2148044: PlsParser fails to read files correctly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by jeremy.wadsack

Modified:
13 years, 7 months ago

Reviewers:
Marsh, Michael Frederick

Base URL:
http://npr-android-app.googlecode.com/svn/trunk/

Visibility:
Public.

Description

The current implementation of PlsParser (as of r97) calls readLine twice for each loop, therefore it only looks at every other line. Because of this it can miss a URL if the file only has one on a even numbered line. Then it throw a NRE because it's trying to evaluate .equals against null returned by readline (because it's at the end of the file). This test and patch fix that.

Patch Set 1 #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -2 lines)			Patch
		Npr/src/org/npr/android/util/PlsParser.java	View		1 chunk	+3 lines, -2 lines	0 comments	Download
		Npr_Test/src/org/npr/android/util/PlsParserTest.java	View		1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Marsh

On 2010/09/09 22:45:52, jeremy.wadsack wrote: > LGTM. Please fix the 1.x branch too.

13 years, 7 months ago (2010-09-12 00:54:54 UTC) #2

jeremy.wadsack

13 years, 7 months ago (2010-09-13 20:00:22 UTC) #3

Done.

r103 on trunk and r104 on vresion_1.x.

--
Jeremy Wadsack


On Sat, Sep 11, 2010 at 5:54 PM, <marshgosnell@gmail.com> wrote:

> On 2010/09/09 22:45:52, jeremy.wadsack wrote:
>
>
> LGTM.  Please fix the 1.x branch too.
>
>
> http://codereview.appspot.com/2148044/
>

Expand All Messages | Collapse All Messages