Issue 21440044: Re-enable Landscape sim and fix inspector link

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 21440044: Re-enable Landscape sim and fix inspector link

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by gary.poster

Modified:
10 years, 6 months ago

Reviewers:
mp+193875, rharding

Visibility:
Public.

Description

Re-enable Landscape sim and fix inspector link Changes to move units to service attributes broke the Landscape simulation because they were buggy, and we had no tests. Fixing that revealed that Landscape links were broken in the inspector if units appeared with Landscape problems while you observed the inspector. This branch also fixes that problem. To QA, run the simulator on the sandbox and create 100 or 200 units in a service. Keep the inspector open after creation. You should see a few Landscape issues appear within a few seconds. If you open up the Landscape sections of the inspector, the link to Landscape at the bottom of the section should have a href that looks vaguely like it might point to Landscape, if Landscape were really hooked up. https://code.launchpad.net/~gary/juju-gui/bug1247903/+merge/193875 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Re-enable Landscape sim and fix inspector link #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+241 lines, -39 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/simulator.js	View	6 chunks	+28 lines, -30 lines	0 comments	Download
M	app/templates/unit-action-buttons.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/viewlets/service-overview.js	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	test/test_inspector_overview.js	View	1 chunk	+102 lines, -0 lines	0 comments	Download
M	test/test_simulator.js	View	3 chunks	+99 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

*** Submitted: Re-enable Landscape sim and fix inspector link Changes to move units to service ...

10 years, 6 months ago (2013-11-05 13:04:17 UTC) #3

gary.poster

10 years, 6 months ago (2013-11-05 13:12:40 UTC) #4

On 2013/11/05 12:18:05, rharding wrote:
> LGTM thanks for the update and tests.

Thank you for the review, Rick.

Expand All Messages | Collapse All Messages