Issue 21430043: Fixes upgrade charm page reload in IE10

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 21430043: Fixes upgrade charm page reload in IE10

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by jeff.pihach

Modified:
10 years, 6 months ago

Reviewers:
matthew.scott, mp+193716

Visibility:
Public.

Description

Fixes upgrade charm page reload in IE10 When clicking a link in the inspector in the upgrade charm section in IE10 the page would reload instead of dispatching to the router. This fixes it by generating complete relative links so that the faulty method in YUI's pjax.base class can parse them and react accordingly. https://code.launchpad.net/~hatch/juju-gui/ie10-upgrade-1246946/+merge/193716 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes upgrade charm page reload in IE10 #

Patch Set 3 : Fixes upgrade charm page reload in IE10 #

Patch Set 4 : Fixes upgrade charm page reload in IE10 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/viewlets/service-overview.js	View	1 2	3 chunks	+11 lines, -2 lines	0 comments	Download
M	test/test_inspector_overview.js	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

rharding

Does this break any external links then? We've got links to launchpad in the charm ...

10 years, 6 months ago (2013-11-03 22:19:27 UTC) #2

jeff.pihach

10 years, 6 months ago (2013-11-06 21:09:15 UTC) #8

*** Submitted:

Fixes upgrade charm page reload in IE10

When clicking a link in the inspector in the upgrade charm
section in IE10 the page would reload instead of dispatching
to the router. This fixes it by generating complete relative
links so that the faulty method in YUI's pjax.base class can
parse them and react accordingly.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/21430043

Expand All Messages | Collapse All Messages