Issue 21390045: Migrate get/set constraints cli to use api

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 21390045: Migrate get/set constraints cli to use api (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by wallyworld

Modified:
10 years, 5 months ago

Reviewers:
mp+193866, axw

Visibility:
Public.

Description

Migrate get/set constraints cli to use api The juju get-constraints and set-constraints commands now use the api. https://code.launchpad.net/~wallyworld/juju-core/cli-api-constraints/+merge/193866 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -74 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/constraints.go	View	3 chunks	+10 lines, -21 lines	0 comments	Download
M	state/api/client.go	View	1 chunk	+17 lines, -2 lines	0 comments	Download
M	state/api/params/params.go	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	state/apiserver/client/client.go	View	2 chunks	+28 lines, -4 lines	4 comments	Download
M	state/apiserver/client/client_test.go	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	state/apiserver/client/perm_test.go	View	2 chunks	+13 lines, -0 lines	0 comments	Download
D	state/statecmd/getconstraints.go	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	state/statecmd/setconstraints.go	View	1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

LGTM with a couple of quibbles https://codereview.appspot.com/21390045/diff/1/state/apiserver/client/client.go File state/apiserver/client/client.go (right): https://codereview.appspot.com/21390045/diff/1/state/apiserver/client/client.go#newcode316 state/apiserver/client/client.go:316: return params.GetConstraintsResults{constraints.Value{}}, err ...

10 years, 5 months ago (2013-11-05 01:37:30 UTC) #2

wallyworld

10 years, 5 months ago (2013-11-05 02:13:09 UTC) #3

https://codereview.appspot.com/21390045/diff/1/state/apiserver/client/client.go
File state/apiserver/client/client.go (right):

https://codereview.appspot.com/21390045/diff/1/state/apiserver/client/client....
state/apiserver/client/client.go:316: return
params.GetConstraintsResults{constraints.Value{}}, err
On 2013/11/05 01:37:30, axw wrote:
> Just params.GetConstraintsResults{} will do, and more obviously a zero value.

Fair point - this was cut and pasted from the deleted statecmd/setconstraints.go
file and I didn't pay too much attention to it cause it was already in the code
base :-)

https://codereview.appspot.com/21390045/diff/1/state/apiserver/client/client....
state/apiserver/client/client.go:326: return params.GetConstraintsResults{cons},
err
On 2013/11/05 01:37:30, axw wrote:
> Generally speaking, we should return zero values with err, shouldn't we? cons
> probably is anyway, but all the same. Otherwise you may as well elide the if
> statement and keep only the first return statement.

Done.

Expand All Messages | Collapse All Messages