Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1255)

Issue 21330043: code review 21330043: freetype/truetype: run compound glyph hinting instructions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by nigeltao
Modified:
10 years, 7 months ago
Reviewers:
bsiegert
CC:
bsiegert, golang-dev, remyoudompheng
Visibility:
Public.

Description

freetype/truetype: run compound glyph hinting instructions. Also add API for vertical metrics.

Patch Set 1 #

Patch Set 2 : diff -r 7333e9fbf3cf https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 7333e9fbf3cf https://code.google.com/p/freetype-go #

Total comments: 1

Patch Set 4 : diff -r 7333e9fbf3cf https://code.google.com/p/freetype-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -34 lines) Patch
M freetype/truetype/glyph.go View 1 2 3 8 chunks +66 lines, -29 lines 0 comments Download
M freetype/truetype/truetype.go View 1 5 chunks +37 lines, -4 lines 0 comments Download
M freetype/truetype/truetype_test.go View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
nigeltao
Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com, remyoudompheng@gmail.com), I'd like you to review this change to https://code.google.com/p/freetype-go
10 years, 7 months ago (2013-11-03 11:30:55 UTC) #1
bsiegert
LGTM https://codereview.appspot.com/21330043/diff/40001/freetype/truetype/glyph.go File freetype/truetype/glyph.go (right): https://codereview.appspot.com/21330043/diff/40001/freetype/truetype/glyph.go#newcode39 freetype/truetype/glyph.go:39: tmp []Point This is not a great variable ...
10 years, 7 months ago (2013-11-04 11:35:38 UTC) #2
nigeltao
10 years, 7 months ago (2013-11-04 22:58:56 UTC) #3
*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=9cad0dfd1b90 ***

freetype/truetype: run compound glyph hinting instructions.

Also add API for vertical metrics.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/21330043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b