Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4940)

Issue 212520043: Reduce code duplication in multiple copies of test_env.py.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by M-A
Modified:
1 month, 3 weeks ago
Reviewers:
omondo1
CC:
omondo1_gmail.com
Base URL:
https://code.google.com/p/swarming@1_move
Visibility:
Public.

Description

Reduce code duplication in multiple copies of test_env.py. Do not eliminate all the copies (yet). This changed the default version from 'default-version' to 'v1a' and app name from whatever in app.yaml to 'sample-app'. Updated a few tests accordingly. Rename replica_app to test_replica_app. It makes it clear it's a test_ and will be caught by skip_files rule once it's moved out of tests/. R=vadimsh@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -175 lines) Patch
D appengine/auth_service/tests/replica_app/app.yaml View 1 chunk +0 lines, -23 lines 0 comments Download
D appengine/auth_service/tests/replica_app/components View 1 chunk +0 lines, -1 line 0 comments Download
D appengine/auth_service/tests/replica_app/main.py View 1 chunk +0 lines, -35 lines 0 comments Download
M appengine/auth_service/tests/replication_smoke_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/auth_service/tests/test_env.py View 1 chunk +2 lines, -23 lines 0 comments Download
A + appengine/auth_service/tests/test_replica_app/app.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/tests/test_replica_app/components View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/auth_service/tests/test_replica_app/main.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A appengine/auth_service/tests/test_support View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/components/test_support/test_env.py View 1 chunk +7 lines, -0 lines 0 comments Download
M appengine/isolate/tests/endpoint_handlers_api_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/isolate/tests/handlers_api_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/isolate/tests/test_env.py View 1 chunk +2 lines, -23 lines 0 comments Download
A appengine/isolate/tests/test_support View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/handlers_api_test.py View 7 chunks +7 lines, -7 lines 0 comments Download
M appengine/swarming/handlers_bot_test.py View 7 chunks +7 lines, -7 lines 0 comments Download
M appengine/swarming/server/task_result_test.py View 4 chunks +5 lines, -7 lines 0 comments Download
M appengine/swarming/server/task_scheduler_test.py View 18 chunks +18 lines, -18 lines 0 comments Download
M appengine/swarming/swarming_bot/os_utilities_test.py View 1 chunk +1 line, -3 lines 0 comments Download
M appengine/swarming/test_env.py View 1 chunk +2 lines, -27 lines 0 comments Download
A appengine/swarming/test_support View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9
M-A
Depends on https://codereview.appspot.com/215360043
8 years, 11 months ago (2015-03-19 01:24:30 UTC) #1
Omondo1
Publish all my draft
1 month, 3 weeks ago (2023-12-27 03:03:13 UTC) #2
Omondo1
1 month, 3 weeks ago (2023-12-27 03:04:36 UTC) #3
Omondo1
On 2015/03/19 01:24:30, M-A wrote: > Depends on https://codereview.appspot.com/215360043
1 month, 3 weeks ago (2023-12-27 03:10:11 UTC) #4
Omondo1
On 2023/12/27 03:10:11, Omondo1 wrote: > On 2015/03/19 01:24:30, M-A wrote: > > Depends on ...
1 month, 3 weeks ago (2023-12-27 03:10:20 UTC) #5
Omondo1
On 2023/12/27 03:10:11, Omondo1 wrote: > On 2015/03/19 01:24:30, M-A wrote: > > Depends on ...
1 month, 3 weeks ago (2023-12-27 03:10:21 UTC) #6
Omondo1
On 2023/12/27 03:10:21, Omondo1 wrote: > On 2023/12/27 03:10:11, Omondo1 wrote: > > On 2015/03/19 ...
1 month, 3 weeks ago (2023-12-27 03:10:30 UTC) #7
Omondo1
On 2023/12/27 03:10:30, Omondo1 wrote: > On 2023/12/27 03:10:21, Omondo1 wrote: > > On 2023/12/27 ...
1 month, 3 weeks ago (2023-12-27 07:59:09 UTC) #8
Omondo1
1 month, 3 weeks ago (2023-12-27 08:00:11 UTC) #9

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b