Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(331)

Issue 212047: code review 212047: release 2010-02-17 part one (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by adg
Modified:
12 years, 9 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

release 2010-02-17 part one

Patch Set 1 #

Patch Set 2 : code review 212047: release 2010-02-17 part one #

Patch Set 3 : code review 212047: release 2010-02-17 part one #

Patch Set 4 : code review 212047: release 2010-02-17 part one #

Patch Set 5 : code review 212047: release 2010-02-17 part one #

Patch Set 6 : code review 212047: release 2010-02-17 part one #

Patch Set 7 : code review 212047: release 2010-02-17 part one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M .hgtags View 2 3 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/release.html View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change.
12 years, 9 months ago (2010-02-17 23:48:16 UTC) #1
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2010-02-17 23:53:16 UTC) #2
rsc
couple missing things 5c/6c/8c: use "cpp" not "/bin/cpp" for external preprocessor (thanks Giles Lean) build: ...
12 years, 9 months ago (2010-02-17 23:56:48 UTC) #3
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2010-02-18 00:03:01 UTC) #4
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2010-02-18 00:23:55 UTC) #5
rsc
LGTM
12 years, 9 months ago (2010-02-18 00:30:23 UTC) #6
adg
12 years, 9 months ago (2010-02-18 00:32:06 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=53fec18b83e2 ***

release 2010-02-17 part one

R=rsc
CC=golang-dev
http://codereview.appspot.com/212047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b