Issue 2118045: Use flag to enable extra security over rpc relay

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2118045: Use flag to enable extra security over rpc relay

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by zhoresh

Modified:
13 years, 8 months ago

Reviewers:
Paul Lindner, Javier Pedemonte, mhermanto, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Ref: https://issues.apache.org/jira/browse/SHINDIG-1409 Add control on weather to enable extra checking of rpc relay domain to be same as container domain.

Patch Set 2 : Update names, using isForceSecure for local var #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
		features/src/main/javascript/features/rpc/wpm.transport.js	View	1	3 chunks	+16 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mhermanto

http://codereview.appspot.com/2118045/diff/1/2 File features/src/main/javascript/features/rpc/wpm.transport.js (right): http://codereview.appspot.com/2118045/diff/1/2#newcode51 features/src/main/javascript/features/rpc/wpm.transport.js:51: var forcesecure = false; nit, camel-case forceSecure. http://codereview.appspot.com/2118045/diff/1/2#newcode139 features/src/main/javascript/features/rpc/wpm.transport.js:139: ...

13 years, 8 months ago (2010-09-03 23:38:55 UTC) #2

lgtm

Expand All Messages | Collapse All Messages