Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2179)

Issue 211041: code review 211041: language spec: make NUL byte rule an implementation res... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by gri
Modified:
12 years, 11 months ago
Reviewers:
CC:
rsc, r, iant, ken2, golang-dev
Visibility:
Public.

Description

language spec: make NUL byte rule an implementation restriction

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review 211041: language spec: make NUL byte rule an implementation res... #

Patch Set 3 : code review 211041: language spec: make NUL byte rule an implementation res... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M doc/go_spec.html View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
gri
Hello rsc, r, iant, ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
12 years, 11 months ago (2010-02-17 19:10:34 UTC) #1
r
LGTM http://codereview.appspot.com/211041/diff/1/2 File doc/go_spec.html (right): http://codereview.appspot.com/211041/diff/1/2#newcode95 doc/go_spec.html:95: NUL character (U+0000). the term "accepted character set" ...
12 years, 11 months ago (2010-02-17 22:58:58 UTC) #2
gri
PTAL iant, rsc, ken? - Robert On Wed, Feb 17, 2010 at 2:58 PM, <r@golang.org> ...
12 years, 11 months ago (2010-02-17 23:39:16 UTC) #3
rsc
LGTM but gofmt needs to keep rejecting NULs
12 years, 11 months ago (2010-02-17 23:44:24 UTC) #4
gri
12 years, 11 months ago (2010-02-17 23:50:36 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=d9a7cf91e8f9 ***

language spec: make NUL byte rule an implementation restriction

R=rsc, r, iant, ken2
CC=golang-dev
http://codereview.appspot.com/211041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b