Issue 211041: code review 211041: language spec: make NUL byte rule an implementation res...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 211041: code review 211041: language spec: make NUL byte rule an implementation res... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by gri

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, r, iant, ken2, golang-dev

Visibility:
Public.

Description

language spec: make NUL byte rule an implementation restriction

Patch Set 2 : code review 211041: language spec: make NUL byte rule an implementation res... #

Patch Set 3 : code review 211041: language spec: make NUL byte rule an implementation res... #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	doc/go_spec.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello rsc, r, iant, ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2010-02-17 19:10:34 UTC) #1

LGTM http://codereview.appspot.com/211041/diff/1/2 File doc/go_spec.html (right): http://codereview.appspot.com/211041/diff/1/2#newcode95 doc/go_spec.html:95: NUL character (U+0000). the term "accepted character set" ...

14 years, 2 months ago (2010-02-17 22:58:58 UTC) #2

gri

PTAL iant, rsc, ken? - Robert On Wed, Feb 17, 2010 at 2:58 PM, <r@golang.org> ...

14 years, 2 months ago (2010-02-17 23:39:16 UTC) #3

gri

14 years, 2 months ago (2010-02-17 23:50:36 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d9a7cf91e8f9 ***

language spec: make NUL byte rule an implementation restriction

R=rsc, r, iant, ken2
CC=golang-dev
http://codereview.appspot.com/211041

Expand All Messages | Collapse All Messages