Fixes bundle vis for charms without versions

Fixes bundle vis for charms without versions

Some of Jorge's bundles didn't have versions specified
so they would not show up in the bundle visualizations
or allow them to be deployed. This fixes that limitation
and improves the error reporting when the user tries to
deploy two bundles with services that have the same names.

https://code.launchpad.net/~hatch/juju-gui/jorge-bundle-vis/+merge/193671

(do not edit description out of merge proposal)

[jeff.pihach, 2013-11-01 23:09:26]

Please take a look.

[jeff.pihach, 2013-11-01 23:12:25]

Reviewer notes

https://codereview.appspot.com/21020043/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/21020043/diff/1/app/models/charm.js#newcode408
app/models/charm.js:408: revision = Y.Lang.isValue(revision) ? '-' + revision :
'';
Allow revision to be specified or not

https://codereview.appspot.com/21020043/diff/1/app/store/env/fakebackend.js
File app/store/env/fakebackend.js (left):

https://codereview.appspot.com/21020043/diff/1/app/store/env/fakebackend.js#o...
app/store/env/fakebackend.js:1449: function nextServiceId(modellist, id) {
Code was not needed

https://codereview.appspot.com/21020043/diff/1/app/store/env/fakebackend.js
File app/store/env/fakebackend.js (right):

https://codereview.appspot.com/21020043/diff/1/app/store/env/fakebackend.js#n...
app/store/env/fakebackend.js:1439: console.log(source);
The original Diff had this throwing an error. That caused any user facing
notifications to not be shown.

https://codereview.appspot.com/21020043/diff/1/app/store/env/fakebackend.js#n...
app/store/env/fakebackend.js:1493: callback(ingestedData);
This allows the user to be notified of ingestion errors in the notification
section.

https://codereview.appspot.com/21020043/diff/1/test/utils.js
File test/utils.js (right):

https://codereview.appspot.com/21020043/diff/1/test/utils.js#newcode200
test/utils.js:200: promiseImport: function(YAMLBundleURL, name, fakebackend) {
Add the ability to pass in a fakebackend to share across imports.

[gary.poster, 2013-11-02 00:39:29]

LGTM.  Thank you!

Gary

[gary.poster, 2013-11-02 00:48:44]

On 2013/11/02 00:39:29, gary.poster wrote:
> LGTM.  Thank you!
> 
> Gary

QAOK too. :-)

[jeff.pihach, 2013-11-02 01:12:33]

*** Submitted:

Fixes bundle vis for charms without versions

Some of Jorge's bundles didn't have versions specified
so they would not show up in the bundle visualizations
or allow them to be deployed. This fixes that limitation
and improves the error reporting when the user tries to
deploy two bundles with services that have the same names.

R=gary.poster
CC=
https://codereview.appspot.com/21020043