Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1373)

Issue 209880043: i#1608 client.modules: use comdlg32.dll on Windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by Byron
Modified:
9 years, 2 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1608 client.modules: use comdlg32.dll on Windows The client.modules test was using advapi32.dll as a sample module to load on Windows. This caused the test to fail in environments having application compatibility enabled and in effect during the test, because that feature causes advapi32.dll to be loaded as a static dependency, resulting in a missing unload event at the end of the test. This commit changes the sample module to comdlg32.dll, which is available on all Windows installations and will not be loaded by application compatibility. Fixes #1608 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M suite/tests/client-interface/modules.c View 1 chunk +2 lines, -2 lines 0 comments Download
M suite/tests/client-interface/modules.template View 1 chunk +2 lines, -2 lines 0 comments Download
M suite/tests/client-interface/modules.dll.c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Byron
9 years, 2 months ago (2015-02-27 10:50:06 UTC) #1
bruening
Please update the issue tracker to explain that it was msys. I would also suggest ...
9 years, 2 months ago (2015-02-27 14:43:31 UTC) #2
Byron
9 years, 2 months ago (2015-02-27 18:17:41 UTC) #3
Committed as
https://github.com/DynamoRIO/dynamorio/commit/acc8b8c73c285db173d14a24a2e69d0...

Final commit log: 
---------------
i#1608 client.modules: use comdlg32.dll on Windows

The client.modules test was using advapi32.dll as a
sample module to load on Windows. This caused the test
to fail in environments such as msys which have
application compatibility enabled and in effect during
the test--that feature causes advapi32.dll to be loaded
as a static dependency, resulting in a missing unload
event at the end of the test. This commit changes the
sample module to comdlg32.dll, which is available on
all Windows installations and will not be loaded by the
application compatibility features

Fixes #1608

Review-URL: https://codereview.appspot.com/209880043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b