Issue 208720043: Backport to es53 branch: 5708,5709,5710

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 208720043: Backport to es53 branch: 5708,5709,5710 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 2 months ago by kpreid_google

Modified:
9 years, 2 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/branches/es53/

Visibility:
Public.

More Reviews

Description

All changes since the previous merge. The merge command was: svn merge -c 5708,5709,5710 ^/trunk and there was one conflict: * Changes to copyBuiltin in taming-membrane.js had to be adjusted for 'privilegedAccess' operations used only in the ES5/3 branch. @r5711

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+368 lines, -215 lines)			Patch
M	.	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/taming-membrane.js	View	1 chunk	+10 lines, -5 lines	0 comments	Download
M	src/com/google/caja/ses/repairES5.js	View	56 chunks	+336 lines, -174 lines	0 comments	Download
M	src/com/google/caja/ses/useHTMLLogger.js	View	3 chunks	+10 lines, -32 lines	0 comments	Download
M	src/com/google/caja/ses/whitelist.js	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-taming-inout-guest.js	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Lgtm

Expand All Messages | Collapse All Messages