Issue 20870043: Autoposition services w/o annotations in bundles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20870043: Autoposition services w/o annotations in bundles

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by matthew.scott

Modified:
10 years, 6 months ago

Reviewers:
mp+193643, jeff.pihach

Visibility:
Public.

Description

Autoposition services w/o annotations in bundles If a bundle does not have service position annotations, generate a default layout and provide a textual warning for the user. As a drive-by, the centering code was fixed to properly center the topology. To QA, check that the following URLs render decent-looking bundles: * /sidebar/search/bundle/~makyo/openstack/2/openstack/:flags:/charmworldv3/?text=makyo * /sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmworldv3/?text=benji#bws-bundle * /sidebar/search/bundle/~hatch/wiki/6/envExport/:flags:/charmworldv3/?text=hatch * /sidebar/search/bundle/~hatch/wiki/7/TestBundle/:flags:/charmworldv3/?text=hatch https://code.launchpad.net/~makyo/juju-gui/investigate-autopos/+merge/193643 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Autoposition services w/o annotations in bundles #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -65 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/bundle.js	View	1	1 chunk	+16 lines, -30 lines	0 comments	Download
M	app/views/topology/bundle.js	View		4 chunks	+41 lines, -5 lines	0 comments	Download
M	test/test_bundle_details_view.js	View		1 chunk	+32 lines, -30 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM QA OK Thanks for this fix it looks muuuuch better. I'm wondering if some ...

10 years, 6 months ago (2013-11-01 17:57:53 UTC) #2

matthew.scott

10 years, 6 months ago (2013-11-01 18:13:11 UTC) #3

*** Submitted:

Autoposition services w/o annotations in bundles

If a bundle does not have service position annotations, generate a default
layout and provide a textual warning for the user.  As a drive-by, the centering
code was fixed to properly center the topology.

To QA, check that the following URLs render decent-looking bundles:
*
/sidebar/search/bundle/~makyo/openstack/2/openstack/:flags:/charmworldv3/?text=makyo
*
/sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmworldv3/?text=benji#bws-bundle
*
/sidebar/search/bundle/~hatch/wiki/6/envExport/:flags:/charmworldv3/?text=hatch
*
/sidebar/search/bundle/~hatch/wiki/7/TestBundle/:flags:/charmworldv3/?text=hatch

R=jeff.pihach
CC=
https://codereview.appspot.com/20870043

Expand All Messages | Collapse All Messages