Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4010)

Issue 20860045: Don't ignore SIGABRT sent by the kernel

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by Luigi Semenzato
Modified:
10 years, 6 months ago
CC:
Sameer
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Visibility:
Public.

Description

Don't ignore SIGABRT sent by the kernel This makes the exception handler treat a SIGABRT generated by the kernel in same way as one generated internally. SIGABRT can be generated internally (typically by calling abort(), but also with signal()) but it can also be sent by the kernel, in which case si_pid is 0. The original code assumes that the signal is sent again upon return, but that doesn't happen for SIGABRT, so the signal is lost. BUG=303075 TEST=tested with alt-volup-X on a chromebook

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M client/linux/handler/exception_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Luigi Semenzato
Are you folks the right reviewers for this? Thanks!
10 years, 6 months ago (2013-11-01 18:38:28 UTC) #1
Mark Mentovai
LGTM
10 years, 6 months ago (2013-11-01 20:09:41 UTC) #2
Mark Mentovai
I don’t know why this was sent to this codereview instance instead of breakpad.appspot.com with ...
10 years, 6 months ago (2013-11-01 20:10:19 UTC) #3
Luigi Semenzato
On 2013/11/01 20:10:19, Mark Mentovai wrote: > I don’t know why this was sent to ...
10 years, 6 months ago (2013-11-01 20:13:25 UTC) #4
Luigi Semenzato
On 2013/11/01 20:13:25, semenzato1 wrote: > On 2013/11/01 20:10:19, Mark Mentovai wrote: > > I ...
10 years, 6 months ago (2013-11-01 20:17:01 UTC) #5
Mark Mentovai
10 years, 6 months ago (2013-11-01 20:42:27 UTC) #6
When you wind up seeking another review, you should do it on Breakpad’s
codereview instance, which will send the review request to the
google-breakpad-dev mailing list. You should be subscribed (e-mail off is OK) to
google-breakpad-dev.

The breakpad imported into Chrome seems to be missing the codereview.settings
file that sets this up correctly. If you svn checkout svn checkout
http://google-breakpad.googlecode.com/svn/trunk/, you should get the whole
thing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b