Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14943)

Issue 20790043: Loop Normals - I

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by b.mont29
Modified:
10 years, 6 months ago
Reviewers:
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

A first patch of loop normals work.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -43 lines) Patch
release/scripts/startup/bl_ui/space_view3d.py View 2 chunks +12 lines, -5 lines 0 comments Download
source/blender/blenkernel/BKE_mesh.h View 2 chunks +5 lines, -1 line 0 comments Download
source/blender/blenkernel/BKE_scene.h View 1 chunk +2 lines, -2 lines 0 comments Download
source/blender/blenkernel/intern/DerivedMesh.c View 13 chunks +116 lines, -16 lines 0 comments Download
source/blender/blenkernel/intern/customdata.c View 6 chunks +17 lines, -5 lines 0 comments Download
source/blender/blenkernel/intern/mesh_evaluate.c View 10 chunks +131 lines, -4 lines 0 comments Download
source/blender/blenkernel/intern/object.c View 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/blenkernel/intern/scene.c View 1 chunk +4 lines, -4 lines 0 comments Download
source/blender/blenloader/intern/readfile.c View 2 chunks +9 lines, -0 lines 0 comments Download
source/blender/blenloader/intern/versioning_defaults.c View 3 chunks +7 lines, -0 lines 0 comments Download
source/blender/editors/space_view3d/drawobject.c View 2 chunks +44 lines, -0 lines 0 comments Download
source/blender/editors/transform/transform_conversions.c View 1 chunk +1 line, -1 line 0 comments Download
source/blender/gpu/intern/gpu_buffers.c View 2 chunks +15 lines, -1 line 0 comments Download
source/blender/makesdna/DNA_customdata_types.h View 3 chunks +6 lines, -2 lines 0 comments Download
source/blender/makesdna/DNA_mesh_types.h View 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/makesdna/DNA_object_types.h View 3 chunks +9 lines, -1 line 0 comments Download
source/blender/makesrna/intern/rna_mesh.c View 3 chunks +27 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_mesh_api.c View 4 chunks +67 lines, -1 line 0 comments Download
source/blender/makesrna/intern/rna_object.c View 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2
b.mont29
10 years, 6 months ago (2013-11-01 13:29:25 UTC) #1
b.mont29
10 years, 6 months ago (2013-11-01 14:51:50 UTC) #2
On 2013/11/01 13:29:25, b.mont29 wrote:

This patch adds several things:

* calc_normals_tangent() mesh API compute tangent space for each loop of the
tri/quad faces, similar to calc_normals_split(), in a temp CDLayer.

* Objects now have two new options, a flag (OB_USE_LOOPNORMALS) to enable loop
normals use, and an angle threshold to automatically "sharpen" edges above that
value.

* These options are used to optionally compute a loop normal CDLayer at the end
of the modifier stack.

* Support to "tessellated loop normals" was also added.

* Basic viewport shading support was also added.

* In edit mode, we can preview loop normals the same way we do with face/vertex
ones.

Notes:
* Viewport drawing is basic for now (only working with VBOs), as I didn’t want
to mess too much with draw code (because of the pending GSoc branch) - in any
case, adapting to new code should not be a problem, it just features a third way
to get vertices' normals.
* Preview not working correctly with subdiv dm currently (probably because of
custom drawing code?), normals are correctly computed though.
* In general, this is kind of draft patch, would need polishing in any case (UI
needs work, new icon for loop, position of loop checkbox/angle threshold not
definitive, etc.).
* I still have to figure a good way to make render engines use this new data,
would also allow us to get rid (actually, replace) the Normals panel in Mesh
buttons.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b